Generate virtual custom attributes with sections #14837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From @simon3z
@gtanzillo I suppose this should go in the release notes and somehow reach the users. cc @Loicavenel |
|
cc @zeari |
…ibutes Example: before assume that we have custom attribute record with #name column ’test1 so from for this custom attribute is virtual_custom_attribute_test1 after assume that we have custom attribute record with #name column ’test1 and #section ’section1’ so from for this custom attribute there is format virtual_custom_attribute_test1:SECTION:section1 Method custom_keys is returning all virtual attributes from object. This new format is used for distinguish custom attributes with same column #name
SECTION separator is :SECTION: in CustomAttributes
Now the method is parsing from virtual attribute also section and this section is used for query to custom attribute table example: virtual_custom_attribute_ANYNAME:SECTION:ANYSECTION is basically query object.custom_attributes.where(:name => ‘ANYNAME’, :section => ‘ANYSECTION’) and old format (virtual_custom_attribute_ANYNAME) is also working
VCA = virtual custom attribute
lpichler
changed the title
lpichler
force-pushed
the
generate_virtual_custom_attributes_with_sections
branch
from
0ce565c to
7e47947
Compare
|
@miq-bot remove_label wip |
|
Checked commits lpichler/manageiq@8da0481~...7e47947 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@simaishi This is second part for https://bugzilla.redhat.com/show_bug.cgi?id=1434077 and #14835 |
|
Backported to Euwe via #14971 |
simaishi
pushed a commit
that referenced
this pull request
Jun 2, 2017
…butes_with_sections Generate virtual custom attributes with sections (cherry picked from commit 688310e) https://bugzilla.redhat.com/show_bug.cgi?id=1458341
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pulled out from #14823
VCA = Virtual Custom Attributes
When there are more custom_attributes with same
namewe were not able to distinguish them.In this PR I distinguish them by column CustomAttribute#section
and I am extending format of virtual custom attributes to
virtual_custom_attribute_NAMEOFATTR:SECTION:docker_labelsand thanks to that it has a format in UI
Docker Labels: NAMEOFATTRandwhen there is no section it looks like:
Custom Attribute: NAMEOFATTRso itmeans that this also works with origin form. (part :SECTION: is not mandatory)
Images
let's assume that we have 3 different custom attributes with name
com.redhat.componentbut with different sections
on the report:
columns in report definition
expression
Links
follow up #14391
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1434077
Depends on
#14835
It is a reason for WIP.
@miq-bot add_label enhancement,core, fine/yes, euwe/yes, wip
@miq-bot assign @gtanzillo
cc @zeari @simon3z