Method to save asset details #14827
Method to save asset details #14827
Conversation
Added save_asset_details_inventory method, which is used to save asset details of a resource.
add a :asset_details child key in save_physical_server_inventory
|
Reopen to rebuild. |
|
The dependency PR is failing tests. Once we get that worked out, we can revisit this one. |
|
@blomquisg the Dependency PR(#14275) was fixed. Can you look these PR? |
Move save_asset_details_inventory from save_inventory.rb to save_inventory_physical_infra.rb
| # | ||
| # Saves asset details information of a resource | ||
| # | ||
| def save_asset_details_inventory(parent, hash) |
There was a problem hiding this comment.
@walteraa can you move this method to save_inventory_physical_infra?
The base save_inventory.rb is more for general purpose inventory methods.
|
Checked commits https://github.com/lenovo/manageiq/compare/8ce72254c71306febd7ebece6dcca827d02a9347~...66974b456226e4c157c9d25c24ce682266a730b7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
The requested change was done @blomquisg |
|
@blomquisg what needs doing on this PR to be merged? |
|
@blomquisg @juliancheal I have done the requested changes. I think this PR can be merged. |
|
@blomquisg is this PR looking good for you? |
This PR add a method to save asset details in MIQ.
This PR depends on #14275