Enable custom actions for Vms API #14817

imtayadeway · 2017-04-19T17:34:47Z

As required by https://www.pivotaltracker.com/n/projects/1914499/stories/142774757

Haven't tested this extensively, just submitting for feedback. @jjlangholtz feel free to pull down and kick the wheels

@miq-bot add-label api, enhancement
@miq-bot assign @abellotti

abellotti · 2017-04-19T17:51:15Z

Nice work @imtayadeway on the model side 🎵 I'll review shortly.

jjlangholtz · 2017-04-19T19:23:41Z

@imtayadeway Pulled down and it looks like everything necessary to render custom actions for vm details on the SUI is available. 💯

abellotti

this is looking great @imtayadeway a couple of questions/comments. Thanks !!

abellotti · 2017-04-19T20:24:00Z

spec/requests/api/vms_spec.rb

+      }
+      expect(response.parsed_body).to include(expected)
+    end
+  end


would you prefer to move these tests to custom_actions_spec.rb ? maybe some stuff can be DRYed up in future PRs between services and vms custom actions specs ?

I might, but prefer to do that in a future PR. The current specs there are set up assuming that the service template is at the center of what's being tested, so would at least need to scope the existing tests in a new context. The resultant diff I thought would be unnecessarily large for this PR

abellotti · 2017-04-19T20:24:09Z

spec/factories/custom_button_set.rb

+
+    after(:create) do |custom_button_set, evaluator|
+      custom_button_set.replace_children(evaluator.children)
+    end


why was this needed ?

I thought it made these a bit nicer (rather than having to do the replace_children after each one).

ahh ok, and this does not affect current users of this Factory outside our API ?

This will not, since currently setting :children in this way would result in:

NoMethodError: undefined method `children=' for #<CustomButtonSet:0x0055c0df9d1ca0> Did you mean? children child_rels

@abellotti I guess it could be possible to build a custom button set, add children, then save. I'll change this to non-destructively shovel children on instead

@abellotti updated in e3c785d

imtayadeway · 2017-04-19T22:15:28Z

app/models/mixins/custom_actions_mixin.rb

+    CustomButton.buttons_for(self).select { |b| b.parent.nil? }
+  end
+
+  def generic_custom_buttons


@abellotti just updated with this to make the contract between this mixin and the host more explicit. It might be nice to add some lower-level tests for Vms now that this has been included - LMK if you'd rather I do that here or in a follow up. Thanks!

this is fine. Thanks.

jjlangholtz · 2017-04-20T13:30:21Z

@imtayadeway I don't know if it is more suitable for this PR or a follow-up, but I am investigating a custom actions BZ and believe there is an error in #custom_action_buttons.

From the SUI, we are using #custom_actions to retrieve all buttons and button_groups, however when a custom action is invoked it uses #custom_action_buttons which does not include the generic buttons (buttons assigned to button_groups) leading to an exception.

imtayadeway · 2017-04-21T18:25:59Z

@miq-bot add-label wip

imtayadeway · 2017-04-21T18:30:44Z

@abellotti marking this as WIP as it will need to be rebased onto #14845 (which I pulled out of this PR)

miq-bot · 2017-04-26T18:12:20Z

This pull request is not mergeable. Please rebase and repush.

imtayadeway · 2017-04-26T18:32:30Z

@miq-bot rm-label wip

abellotti · 2017-04-26T18:40:43Z

app/models/mixins/custom_actions_mixin.rb

+
+  def generic_button_group
+    CustomButton.buttons_for("Service").select { |button| !button.parent.nil? }
+  end


shouldn't be defined here, just the one on line 48

miq-bot · 2017-04-26T18:47:32Z

Checked commits imtayadeway/manageiq@01d1771~...8318d5c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
6 files checked, 0 offenses detected
Everything looks fine. ⭐

abellotti · 2017-04-26T19:12:53Z

Thanks @imtayadeway this is a great enhancement !! 🎵

chessbyte · 2017-05-18T14:47:10Z

@abellotti @gtanzillo do you feel comfortable labeling this fine/yes? If so, please do so.

chrispy1 · 2017-05-18T15:23:18Z

@miq-bot add_label blocker

Enable custom actions for Vms API (cherry picked from commit a1d985c) https://bugzilla.redhat.com/show_bug.cgi?id=1450502

simaishi · 2017-05-18T17:50:44Z

Fine backport details:

$ git log -1
commit 28fa95221971cf0baee0d806e12208d78bd1b6ba
Author: Alberto Bellotti <[email protected]>
Date:   Wed Apr 26 15:13:14 2017 -0400

    Merge pull request #14817 from imtayadeway/api/vm-custom-actions
    
    Enable custom actions for Vms API
    (cherry picked from commit a1d985ca1dd6be423c8623cef4a740cc6acef4e1)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1450502

miq-bot added api enhancement labels Apr 19, 2017

miq-bot assigned abellotti Apr 19, 2017

imtayadeway force-pushed the api/vm-custom-actions branch from 3e95b04 to 663ce76 Compare April 19, 2017 17:57

abellotti reviewed Apr 19, 2017

View reviewed changes

imtayadeway force-pushed the api/vm-custom-actions branch 2 times, most recently from 3a34604 to ab015e0 Compare April 19, 2017 22:12

imtayadeway commented Apr 19, 2017

View reviewed changes

imtayadeway force-pushed the api/vm-custom-actions branch from ab015e0 to 83e1b51 Compare April 20, 2017 20:35

imtayadeway mentioned this pull request Apr 20, 2017

Remove stubbing in ServiceTemplate#custom_actions spec #14833

Merged

miq-bot changed the title ~~Enable custom actions for Vms API~~ [WIP] Enable custom actions for Vms API Apr 21, 2017

miq-bot added the wip label Apr 21, 2017

imtayadeway mentioned this pull request Apr 21, 2017

Ensure grouped generic custom buttons can be invoked #14845

Merged

imtayadeway force-pushed the api/vm-custom-actions branch from 83e1b51 to e0daf3a Compare April 21, 2017 18:29

miq-bot added the unmergeable label Apr 26, 2017

imtayadeway added 3 commits April 26, 2017 11:25

Allow custom button set factory to accept members

01d1771

Give custom buttons to vms

be0af5a

Enable custom actions in the Vms API

f349450

imtayadeway force-pushed the api/vm-custom-actions branch from e0daf3a to 3c87bbe Compare April 26, 2017 18:32

miq-bot changed the title ~~[WIP] Enable custom actions for Vms API~~ Enable custom actions for Vms API Apr 26, 2017

miq-bot removed wip unmergeable labels Apr 26, 2017

abellotti reviewed Apr 26, 2017

View reviewed changes

Extract CustomActionsMixin

8318d5c

imtayadeway force-pushed the api/vm-custom-actions branch from 3c87bbe to 8318d5c Compare April 26, 2017 18:45

abellotti added this to the Sprint 60 Ending May 8, 2017 milestone Apr 26, 2017

abellotti merged commit a1d985c into ManageIQ:master Apr 26, 2017

simaishi mentioned this pull request May 18, 2017

Added custom buttons to VM details page ManageIQ/manageiq-ui-service#750

Merged

gtanzillo added the fine/yes label May 18, 2017

miq-bot added the blocker label May 18, 2017

simaishi pushed a commit that referenced this pull request May 18, 2017

Merge pull request #14817 from imtayadeway/api/vm-custom-actions

28fa952

Enable custom actions for Vms API (cherry picked from commit a1d985c) https://bugzilla.redhat.com/show_bug.cgi?id=1450502

simaishi added fine/backported and removed fine/yes labels May 18, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable custom actions for Vms API #14817

Enable custom actions for Vms API #14817

imtayadeway commented Apr 19, 2017

abellotti commented Apr 19, 2017

jjlangholtz commented Apr 19, 2017

abellotti left a comment

abellotti Apr 19, 2017

imtayadeway Apr 19, 2017

abellotti Apr 19, 2017

abellotti Apr 19, 2017

imtayadeway Apr 19, 2017

abellotti Apr 19, 2017

imtayadeway Apr 19, 2017

imtayadeway Apr 19, 2017

imtayadeway Apr 19, 2017

abellotti Apr 19, 2017

imtayadeway Apr 19, 2017

abellotti Apr 26, 2017

jjlangholtz commented Apr 20, 2017

imtayadeway commented Apr 21, 2017

imtayadeway commented Apr 21, 2017

miq-bot commented Apr 26, 2017

imtayadeway commented Apr 26, 2017

abellotti Apr 26, 2017

miq-bot commented Apr 26, 2017

abellotti commented Apr 26, 2017

chessbyte commented May 18, 2017

chrispy1 commented May 18, 2017

simaishi commented May 18, 2017

Enable custom actions for Vms API #14817

Enable custom actions for Vms API #14817

Conversation

imtayadeway commented Apr 19, 2017

abellotti commented Apr 19, 2017

jjlangholtz commented Apr 19, 2017

abellotti left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jjlangholtz commented Apr 20, 2017

imtayadeway commented Apr 21, 2017

imtayadeway commented Apr 21, 2017

miq-bot commented Apr 26, 2017

imtayadeway commented Apr 26, 2017

Choose a reason for hiding this comment

miq-bot commented Apr 26, 2017

abellotti commented Apr 26, 2017

chessbyte commented May 18, 2017

chrispy1 commented May 18, 2017

simaishi commented May 18, 2017