chargeback - group results with unknown project under 'unknown project'

[zeari]

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1442158
containers without an identifiable project will grouped under "Unknown Project" in Chargeback for container images reports

@gtanzillo @lpichler @isimluk Please review
cc @simon3z

[zeari]

@miq-bot add_label chargeback, providers/containers

[miq-bot]

Checked commit zeari@86e8b82 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍪

[isimluk]

👍 This will work.

Good idea with naming it unknown and showing it to the user.

[gtanzillo]

This seems like it should address the case where a container image is not connected a project. Were you able to test this out to make sure the the "unknown project" can be displayed properly on the report?

[isimluk]

For the future reference, the traceback was:

[NoMethodError]: undefined method `id' for nil:NilClass  Method:[rescue in _async_generate_table]
[----] E, ERROR -- : /var/www/miq/vmdb/app/models/chargeback_container_image.rb:61:in `default_key'
/var/www/miq/vmdb/app/models/chargeback.rb:32:in `report_row_key'
/var/www/miq/vmdb/app/models/chargeback.rb:11:in `block in build_results_for_report_chargeback'
/var/www/miq/vmdb/app/models/chargeback/consumption_history.rb:31:in `block (2 levels) in for_report'
/var/www/miq/vmdb/app/models/chargeback/consumption_history.rb:27:in `each'
/var/www/miq/vmdb/app/models/chargeback/consumption_history.rb:27:in `block in for_report'
/var/www/miq/vmdb/app/models/chargeback/consumption_history.rb:13:in `each'
/var/www/miq/vmdb/app/models/chargeback/consumption_history.rb:13:in `each_cons'
/var/www/miq/vmdb/app/models/chargeback/consumption_history.rb:13:in `for_report'
/var/www/miq/vmdb/app/models/chargeback.rb:8:in `build_results_for_report_chargeback'
/var/www/miq/vmdb/app/models/chargeback_container_image.rb:55:in `build_results_for_report_ChargebackContainerImage'
/var/www/miq/vmdb/app/models/miq_report/generator.rb:198:in `_generate_table'
/var/www/miq/vmdb/app/models/miq_report/generator.rb:172:in `block in generate_table’

[simon3z]

@gtanzillo instead of creating something custom for this entry can the reporting system cope with nils? Maybe transforming those in special vaules e.g. "Missing Field".

[zeari]

This seems like it should address the case where a container image is not connected a project. Were you able to test this out to make sure the the "unknown project" can be displayed properly on the report?

@gtanzillo Yes. The screenshot above is the result of running the report after setting the project_id to nil on a pod(container_group)

[gtanzillo]

Thanks @zeari I forgot to look at the screenshot! 👍
@simon3z

@gtanzillo instead of creating something custom for this entry can the reporting system cope with nils? Maybe transforming those in special values e.g. "Missing Field".
I think the reporting system will handle a grouping of nil without blowing up. But, I think its better that there is an actual name on the grouping because the reporting system will just show the nil.

[simon3z]

I think the reporting system will handle a grouping of nil without blowing up. But, I think its better that there is an actual name on the grouping because the reporting system will just show the nil.

@gtanzillo if the column is named "Project" (as in this case) and the cell has a value of "Missing Field" (when nil) then it seems descriptive enough.

[isimluk]

I think there might be some confusion going on. The project AR does never get down to the report formatter. The project AR never leaves the ChargebackContainerProject class.

[simaishi]

Fine backport details:

$ git log -1
commit 005d38df9ece2325a7c9ef3419aa29f1932b0b1b
Author: Šimon Lukašík <[email protected]>
Date:   Wed Apr 19 16:14:37 2017 +0200

    Merge pull request #14811 from zeari/fix_nil_project_cb_report
    
    chargeback - group results with unknown project under 'unknown project'
    (cherry picked from commit d573adcf7585e17fdcc961912303a27e2c66ee65)

[simaishi]

Euwe backport details:

$ git log -1
commit 834739f2b83494293f89241efde3b8ebd1706e06
Author: Šimon Lukašík <[email protected]>
Date:   Wed Apr 19 16:14:37 2017 +0200

    Merge pull request #14811 from zeari/fix_nil_project_cb_report
    
    chargeback - group results with unknown project under 'unknown project'
    (cherry picked from commit d573adcf7585e17fdcc961912303a27e2c66ee65)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1444041