Fix broken stylesheet path for PDFs

[hayesr]

The code points to the wrong place after the UI repo split. This changes it to point to the stylesheet under the UI engine.

This fixes basic PDF styles, but images remain to be addressed.

Dependent on ManageIQ/manageiq-ui-classic#1332 to work.

Related:

• https://bugzilla.redhat.com/show_bug.cgi?id=1447940
• [WIP] Base64 encode images for PDFs manageiq-ui-classic#1090

Currently

After

[hayesr]

@miq-bot add_label bug

[imtayadeway]

@hayesr could this be related to https://bugzilla.redhat.com/show_bug.cgi?id=1442067 ?

[hayesr]

@imtayadeway It could indeed. Not sure how graphs are generated, this fixes basic stylesheets, but things like images will take more. (I'm also looking into that)

[bdunne]

I think this logic neeeds to be more pluggable to find stylesheets provided by other pluggable components.

[hayesr]

@bdunne perhaps this generator shouldn't try to figure out the path at all. We can just expect the thing that's calling it to use the right path.

[hayesr]

Is there an easy fix to make this pluggable? Otherwise, this fixes a bug now and maybe we can punt making it flexible until that's needed?

[bdunne]

@hayesr something like this would work:

Vmdb::Plugins.instance.vmdb_plugins.each do |plugin|
  plugin.root.join("app/assets/stylesheets", whatever)
end

You may want to use detect rather than each if you're only looking for one. And you'll need to see is the file exists.

[hayesr]

@bdunne I run into a weird situation where Vmdb::Plugins.instance.vmdb_plugins is empty some times, any ideas?

[bdunne]

It can be an empty array if you reload! in dev mode.

[miq-bot]

Checked commit hayesr@46719a3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

[dclarizio]

@hayesr can you add a before/after screenshot of the PDFs? Thx, Dan

[hayesr]

Restarting CI

[hayesr]

@bdunne Ready for another look.

[h-kataria]

looks good

[bdunne]

👍 LGTM

[simaishi]

@hayesr @bdunne can this be euwe/yes? The BZ has the flag set and ManageIQ/manageiq-ui-classic#1332 is euwe/yes as well.

[bdunne]

@simaishi No, Vmdb::Plugins doesn't exist in euwe, and the UI wasn't split at that time. I think we need a separate PR for euwe.

[simaishi]

@bdunne thank you.
@hayesr I'll mark as euwe/conflict for now, please remove the label when Euwe PR is ready.

[hayesr]

@simaishi If #15131 can be backported it would solve the same problem.

[simaishi]

@hayesr In that case, is ManageIQ/manageiq-ui-classic#1332 still needed or just need ManageIQ/manageiq-ui-classic#1363?

With multiple PRs it's getting harder to track what's needed and not. Can you please add/remove fine/yes and euwe/yes labels where needed? I won't backport any until all needed PRs for the BZ are merged, so the labels can be added later if that's easier.

[hayesr]

@miq-bot remove_label euwe/conflict euwe/yes
@miq-bot add_label euwe/no fine/no

@simaishi Ok, changing this one to euwe/no fine/no because the other solution is better. (branch-specific versions of #15131) may still be needed, though) Both UI PRs are needed.

[miq-bot]

@hayesr Cannot remove the following label because they are not recognized: euwe/conflict euwe/yes

[miq-bot]

@hayesr Cannot apply the following label because they are not recognized: euwe/no fine/no