Fixed bug: timeout was not triggered for Image Scanning Job after removing Job#agent_class #14791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrudman
force-pushed
the
fixed-bug-execute-timeout-for-container-image-scanning
branch
2 times, most recently
from
11faad8 to
c805ebf
Compare
|
@miq-bot add-label fine/yes |
|
@miq-bot assign @gtanzillo |
yrudman
changed the title
yrudman
force-pushed
the
fixed-bug-execute-timeout-for-container-image-scanning
branch
from
c805ebf to
5f1feb2
Compare
|
@jrafanie could you review |
jrafanie
reviewed
Apr 19, 2017
spec/models/job_spec.rb
Outdated
| relation = double("ActiveRecord::Relations") | ||
| allow(Job).to receive(:in_my_region).and_return(relation) | ||
| allow(relation).to receive(:where).and_return(relation) | ||
| allow(relation).to receive(:each).and_yield(@job) |
There was a problem hiding this comment.
Can you create one or more jobs in the database that you check afterwards for timeout? The mocking and expectations are making it hard to tell what's going on.
There was a problem hiding this comment.
ok, stubbing removed
…ot executed for failed Image Scanning job. Fixes ManageIQ#14788
yrudman
force-pushed
the
fixed-bug-execute-timeout-for-container-image-scanning
branch
from
4fe0d92 to
0f98bf8
Compare
yrudman
force-pushed
the
fixed-bug-execute-timeout-for-container-image-scanning
branch
from
0f98bf8 to
abaf456
Compare
|
Checked commits yrudman/manageiq@01fb29e~...abaf456 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
jrafanie
approved these changes
Apr 20, 2017
jrafanie
deleted the
fixed-bug-execute-timeout-for-container-image-scanning
branch
simaishi
pushed a commit
that referenced
this pull request
Apr 20, 2017
…container-image-scanning Fixed bug: timeout was not triggered for Image Scanning Job after removing Job#agent_class (cherry picked from commit 532b886)
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: Container Image Scanning Jobs do not get timeout when scanning pod fails.
Issue: #14788
Fix: put back original logic (prior to #14356) but use
MiqServerinstead ofagent_class@miq-bot add-label bug, smart state