Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use interpolation inside a gettext string #14758

Conversation

mzazrivec
Copy link
Contributor

@mzazrivec mzazrivec commented Apr 13, 2017

Same fix for fine branch will come in a separate PR.

@miq-bot add_label fine/no

@miq-bot
Copy link
Member

miq-bot commented Apr 13, 2017

Checked commit mzazrivec@884d6e2 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 🏆

@chessbyte chessbyte self-assigned this Apr 17, 2017
@chessbyte chessbyte merged commit 2983b46 into ManageIQ:master Apr 17, 2017
@chessbyte chessbyte added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 17, 2017
@simaishi
Copy link
Contributor

Backported to Fine via #14759

@chessbyte chessbyte added the bug label Apr 26, 2017
@mzazrivec mzazrivec deleted the dont_user_interpolation_inside_a_gettext_string branch May 10, 2017 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants