Speed up MiqEventDefinitionSet.seed #14721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiqEventDefinitionSet is static union. It is dumb to use 13 selects
on every start-up (during the db lock) to ensure that the union is
in place.
On my system, the `10_000.times { MiqEventDefinitionSet.seed }` gives:
:kiss: | rows | selects | time | %
-------| ------ | ------- | ---- | ----
Before | 130000 | 130000 | 123s | 100%
After | 130000 | 10000 | 34s | 27%
|
Checked commit isimluk@ad4c647 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Hm, I just found this method is called TWICE on start-up. ♻️ |
simaishi
pushed a commit
that referenced
this pull request
Apr 11, 2017
…seeds Speed up MiqEventDefinitionSet.seed (cherry picked from commit 42e8fc0)
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MiqEventDefinitionSet is static union. It is unfortunate to use 13 selects on every start-up (during the db lock) to ensure that the union is in place.
On my system, the
10_000.times { MiqEventDefinitionSet.seed }gives:Note: MiqEventDefinition.seed is second biggest abuser after BlackListedEvent (#14712)