Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate - Provisioning First and Last name are no longer required. #14694

Merged
merged 1 commit into from
Apr 10, 2017

Conversation

billfitzgerald0120
Copy link
Contributor

Fields are not being populate during life-cycle provisioning so
There is no reason to make them required.

This eliminates 2 required fields when provisioning.

https://bugzilla.redhat.com/show_bug.cgi?id=1349607

@miq-bot add_label bug, fine/yes

@billfitzgerald0120
Copy link
Contributor Author

@miq-bot add_labe automate, provisioning

@miq-bot
Copy link
Member

miq-bot commented Apr 7, 2017

@billfitzgerald0120 unrecognized command 'add_labe', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@miq-bot
Copy link
Member

miq-bot commented Apr 7, 2017

This pull request is not mergeable. Please rebase and repush.

@billfitzgerald0120
Copy link
Contributor Author

@miq-bot add_label automate, provisioning

…ired.

Fields are not being populate during life-cycle provisioning so
There is no reason to make them required.

This eliminates 2 required fields when provisioning.

https://bugzilla.redhat.com/show_bug.cgi?id=1349607
@miq-bot
Copy link
Member

miq-bot commented Apr 10, 2017

Checked commit billfitzgerald0120@62dcdce with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🍰

@billfitzgerald0120
Copy link
Contributor Author

@tinaafitz
Please Review

@tinaafitz
Copy link
Member

@billfitzgerald0120 Looks good.
@mkanoor Please review.

@gmcculloug gmcculloug self-assigned this Apr 10, 2017
@mkanoor
Copy link
Contributor

mkanoor commented Apr 10, 2017

👍

@mkanoor mkanoor requested review from lwander and removed request for lwander April 10, 2017 18:47
@gmcculloug gmcculloug merged commit fa4d05b into ManageIQ:master Apr 10, 2017
@gmcculloug gmcculloug added this to the Sprint 58 Ending Apr 10, 2017 milestone Apr 10, 2017
simaishi pushed a commit that referenced this pull request Apr 11, 2017
Automate - Provisioning First and Last name are no longer required.
(cherry picked from commit fa4d05b)

https://bugzilla.redhat.com/show_bug.cgi?id=1441270
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 40a1ac584534fd7954e2810f69cdc3abfd64ff8f
Author: Greg McCullough <[email protected]>
Date:   Mon Apr 10 16:50:41 2017 -0400

    Merge pull request #14694 from billfitzgerald0120/name_not_required
    
    Automate - Provisioning First and Last name are no longer required.
    (cherry picked from commit fa4d05bf081f03a9e11db5175086ffe43482da48)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1441270

simaishi pushed a commit that referenced this pull request Apr 17, 2017
Automate - Provisioning First and Last name are no longer required.
(cherry picked from commit fa4d05b)

https://bugzilla.redhat.com/show_bug.cgi?id=1441423
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit e4f721dba4ac65c61d4b3831315f08e2ce0e8864
Author: Greg McCullough <[email protected]>
Date:   Mon Apr 10 16:50:41 2017 -0400

    Merge pull request #14694 from billfitzgerald0120/name_not_required
    
    Automate - Provisioning First and Last name are no longer required.
    (cherry picked from commit fa4d05bf081f03a9e11db5175086ffe43482da48)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1441423

billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-providers-azure that referenced this pull request May 22, 2017
…uired.

Fields are not being populate during life-cycle provisioning so
There is no reason to make them required.

This eliminates 2 required fields when provisioning.

https://bugzilla.redhat.com/show_bug.cgi?id=1454351

I did this previously in ManageIQ,  see

ManageIQ/manageiq#14694

@miq-bot add_label bug,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants