Fix for External Automation Manager Inventory Group #14691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
requested changes
Apr 7, 2017
| @@ -1,2 +1,2 @@ | |||
| class ManageIQ::Providers::AnsibleTower::AutomationManager::Inventory < ManageIQ::Providers::ExternalAutomationManager::InventoryGroup | |||
| class ManageIQ::Providers::AnsibleTower::AutomationManager::Inventory < ManageIQ::Providers::ExternalAutomationManager::InventoryRootGroup | |||
There was a problem hiding this comment.
The class you are trying to inherit from is missing, can you add it for External and Embedded as well? Thanks for fixing this bug 👍
lgalis
force-pushed
the
inventory_root_group_model_fix
branch
from
7aa778f to
69a2979
Compare
|
Checked commit lgalis@69a2979 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
lgalis
changed the title
|
@bdunne - please review |
bdunne
approved these changes
Apr 10, 2017
simaishi
pushed a commit
that referenced
this pull request
Apr 11, 2017
Fix for External Automation Manager Inventory Group (cherry picked from commit 9a09086)
|
Fine backport details: |
|
@lgalis @dclarizio The BZ has 5.7.z flag too, this can be backported to Euwe? |
|
@simaishi - the Ansible Tower code was changed and moved in 5.8, so this PR cannot be backported to Euwe - I will create a separate PR for that. |
|
@lgalis Marked as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
Steps for Testing/QA