Changed report name to be consistent with actual produced report.

[nimrodshn]

Fixed report name to be consistent with report produced, also fixed OOTB chart based on that report.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1436706
Before:

After:

Chart (Top right one):

cc: @simon3z @moolitayer @yaacov

[yaacov]

a. In the BZ it say the currect title of the report table should be "Nodes by Number of CPU Cores"
not "Nodes per CPU Cores"

b. The report chart on the other hand show "number of nodes per cpu cores"

[nimrodshn]

a. In the BZ it say the currect title of the report table should be "Nodes by Number of CPU Cores"
not "Nodes per CPU Cores"

Fixed.

b. The report chart on the other hand show "number of nodes per cpu cores"

from what I understanf its OKAY for a chart to show something other than the report it grabs information from - i.e. a chart grabs information from a report in order to show some info; It isn't an exact copy of that report otherwise there is no use for charts - just use reports instead.

Meaning the term 'report chart' is empty - charts draw information from reports but are different entities from them. [thats how I think of this..]

[nimrodshn]

[miq-bot]

Checked commit nimrodshn@3f8a4b6 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. ⭐

[yaacov]

LGTM 👍

Meaning the term 'report chart' is empty - charts draw information from reports but are different entities from them. [thats how I think of this..]

A chart should have a title .... but that is a different bug :-)

[yaacov]

p.s.

The chart doesn't have a title or a legend !? so it's a mystery chart :-)

[nimrodshn]

The chart doesn't have a title or a legend !? so it's a mystery chart :-)

a. It does have a title.
b. As far as I know we do not support legends...

[simon3z]

@nimrodshn @yaacov since there are tens or hundreds of nodes displaying them in a table ordered by CPU cores is not relevant.
The idea was to have a table/chart that is displaying the number of nodes by CPU cores:

Number of Nodes	Number of CPU Cores
4	8
32	4

Of course the best output for this is the chart based on this data.

Please check #3220 when I introduced it (see how a field was named "Number of Nodes per CPU Cores"). Did something change in the reporting system? Is it possible to have the report as it was initially designed?

[nimrodshn]

@zeari you're opinion?

[zeari]

@nimrodshn I dont know of a way to leverage the reports generator to do this.
what we want here is to group by 'Number of CPU Cores' and get counts for each. I think the best we can do is get counts through the consolidation tab in the reports editor.

[nimrodshn]

@simon3z I'm not sure we can produce the report you described as now, also looking at the original report it doesn't seem like it had looked like this to begin with... Thoughts?

[simon3z]

LGTM 👍
@gtanzillo @nimrodshn @zeari @kbrock in an already existing system are these going to be duplicated because we changed the name?
@miq-bot assign gtanzillo

[nimrodshn]

@simon3z looking at my app there aren't any dups.

[kbrock]

Not sure what will happen to entries in MiqQueue that point to the old widget names.
To be honest, this should be fine.

Other than that, this looks great

[nimrodshn]

@simon3z FYI.

[simon3z]

@simon3z FYI.

@nimrodshn the PR is assigned to @gtanzillo (ping?)

[gtanzillo]

👍 LGTM

[simaishi]

@gtanzillo @simon3z should this be fine/yes (as per BZ)?

[gtanzillo]

👍 fine/yes

[simaishi]

Fine backport details:

$ git log -1
commit c5cc90db5db590cbee648c6917aa3008d6d77940
Author: Gregg Tanzillo <[email protected]>
Date:   Tue May 23 13:56:49 2017 -0400

    Merge pull request #14646 from nimrodshn/fix_report_name_nodes_per_cpu
    
    Changed report name to be consistent with actual produced report.
    (cherry picked from commit 5e34877484eb497ba30dadd47bcbc47860192db0)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1461541

[simaishi]

Also fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1436698