Restrict historical metrics collection #14640
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are going to fail here ... need to update one of the specs |
blomquisg
force-pushed
the
maximum_historical_metrics
branch
from
08f8395 to
e6cc693
Compare
Previously, if the `last_perf_capture_on` value was very very old, MIQ would attempt to gather all of the metrics from `last_perf_capture_on` until now. ManageIQ#14332 introduced the concept of grouping the historical metrics by days, so the collector worker would not try to gather *ALL* of the metrics at once. This change further restricts the metrics by favoring the more recent date between: * `last_perf_capture_on` * Metric::Capture.historical_start_time If `last_perf_capture_on` is too far in the past, `Metric::Capture.historical_start_time` will be a forceful override.
blomquisg
force-pushed
the
maximum_historical_metrics
branch
from
e6cc693 to
cf68872
Compare
|
Checked commit blomquisg@cf68872 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
This pull request is not mergeable. Please rebase and repush. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the
last_perf_capture_onvalue was very very old, MIQ would attempt to gather all of the metrics fromlast_perf_capture_onuntil now.#14332 introduced the concept of grouping the historical metrics by days, so the collector worker would not try to gather ALL of the metrics at once.
This change further restricts the metrics by favoring the more recent date between:
last_perf_capture_onIf
last_perf_capture_onis too far in the past,Metric::Capture.historical_start_timewill be a forceful override.