Ensure remote shells generated by SCVMM are closed when finished #14591
Conversation
| shell.close | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
@djberg96 can you place both "with_winrm_shell" definitions contiguous in the source file? Since you're adding both of them I can see no reason to have them at opposite ends of the file. Otherwise LTGM.
There was a problem hiding this comment.
@jerryk55 Ok, I reorganized the code as requested.
|
Checked commits https://github.com/djberg96/manageiq/compare/54ec2614becbde33fb6893e445dd55caae0b06fb~...6643953454105765f1074225ec75873a0e3a0619 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@djberg96 latest changes good. 👍 |
|
@miq-bot add_label fine/yes |
|
@djberg96 unrecognized command 'fine', ignoring... Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
|
@miq-bot add_label darga/no |
|
@miq-bot add_label euwe/no |
Ensure remote shells generated by SCVMM are closed when finished (cherry picked from commit 5f36311) https://bugzilla.redhat.com/show_bug.cgi?id=1438593
|
Fine backport details: |
The WinRM shells being created for SCVMM are not being closed properly. It seems we did not completely update the code for WinRM 2.x completely when we upgraded. The result is that sometimes the server will refuse the connection until some of the existing shells eventually time out. This fixes that by ensuring a shell is closed once finished.
It also takes advantage of the stdout and stderr methods, and removes an unnecessary variable assignment.
Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1436180
Replaces #13637