API support for adding/removing Policies to/from Policy Profiles #14575
Conversation
|
@miq-bot add_label enhancement, api, control |
dkorn
changed the title
dkorn
force-pushed
the
add_policy_to_policy_profile
branch
from
4274818 to
8d5ff56
Compare
|
@moolitayer @simon3z @zeari @abellotti please review |
spec/requests/api/policies_spec.rb
Outdated
|
|
||
| expect(response).to have_http_status(:ok) | ||
| expect(ps2.reload.miq_policies.count).to eq(0) | ||
| end |
There was a problem hiding this comment.
these tests should go in policies_assignment_spec.rb, there are helper method you can simply call.
There was a problem hiding this comment.
Done, thanks!
Notice I added object.reload in the unassign spec, without it the test fails.
| @@ -8,11 +8,19 @@ def policies_query_resource(object) | |||
| end | |||
|
|
|||
| def policies_assign_resource(object, _type, id = nil, data = nil) | |||
| policy_assign_action(object, :policies, id, data) | |||
| if object.kind_of?(collection_class(:policy_profiles)) | |||
| object.add_member(policy_specified(id, data, :policies, MiqPolicy)) | |||
There was a problem hiding this comment.
would prefer having add_policy and remove_policy provided in the MiqPolicySet model.
There was a problem hiding this comment.
I did the change, hope I understood you correctly
Currently, it is only possible to add/remove MiqPolicy from
MiqPolicySet using the UI.
This change adds to API support for these operations, using the
assign/unassign actions.
Example:
POST /api/policy_profiles/:id/policies
Body:
{
"action": "assign",
"resources": [
{ "href": "/api/policies/1" },
{ "href": "/api/policies/2" }
]
}
dkorn
force-pushed
the
add_policy_to_policy_profile
branch
from
8d5ff56 to
7522f32
Compare
* miq_policy_set: add_policy, remove_policy, get_policies * api.yml: add identifier * move assignment specs
dkorn
force-pushed
the
add_policy_to_policy_profile
branch
from
7522f32 to
20ac36a
Compare
|
Checked commits dkorn/manageiq@7aac779~...20ac36a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/models/miq_policy_set.rb
|
|
Thanks @dkorn for the API Enhancement. LGTM!! |
Currently, it is only possible to add/remove MiqPolicy from MiqPolicySet using the UI.
This change adds to API support for these operations, using the
assign/unassignactions.Example:
POST /api/policy_profiles/:id/policiesBody:
{ "action": "assign", "resources": [ { "href": "/api/policies/1" }, { "href": "/api/policies/2" } ] }