Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce policies type to be either "compliance" or "control" #14519

Merged
merged 2 commits into from
Mar 30, 2017
Merged

Enforce policies type to be either "compliance" or "control" #14519

merged 2 commits into from
Mar 30, 2017

Conversation

isimluk
Copy link
Member

@isimluk isimluk commented Mar 27, 2017

No description provided.

@miq-bot miq-bot added the wip label Mar 27, 2017
@gmcculloug gmcculloug requested a review from lfu March 29, 2017 13:58
@gmcculloug
Copy link
Member

@lfu Can you verify the validates logic makes sense and if so the tests will need to be updated as part of this change.

lfu
lfu approved these changes Mar 29, 2017
View reviewed changes
Copy link
Member

@lfu lfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isimluk isimluk changed the title [WIP] Enforce policies type to be either "compliance" or "control" Enforce policies type to be either "compliance" or "control" Mar 30, 2017
@isimluk
Copy link
Member Author

isimluk commented Mar 30, 2017

Thanks @lfu, @gmcculloug for review!

It turns out, that spec fix is quite easy. Labeling fine/yes as this relates to bz https://bugzilla.redhat.com/show_bug.cgi?id=1435780

@isimluk isimluk added fine/yes and removed wip labels Mar 30, 2017
@miq-bot
Copy link
Member

miq-bot commented Mar 30, 2017

Checked commits isimluk/manageiq@3e95a85~...2bede28 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 🍰

@lfu
Copy link
Member

lfu commented Mar 30, 2017

👍 Nice!

@gmcculloug
Copy link
Member

I was hoping it would be that easy. Thanks @isimluk.

@gmcculloug gmcculloug merged commit 6b88182 into ManageIQ:master Mar 30, 2017
@gmcculloug gmcculloug added this to the Sprint 58 Ending Apr 10, 2017 milestone Mar 30, 2017
@skateman skateman mentioned this pull request Mar 30, 2017
Merged
@himdel
Copy link
Contributor

himdel commented Mar 30, 2017

When backporting to fine, please backport together with ManageIQ/manageiq-ui-classic#851

simaishi pushed a commit that referenced this pull request Mar 30, 2017
@gmcculloug @simaishi
Merge pull request #14519 from isimluk/rhbz#1435780
20ed0de 
Enforce policies type to be either "compliance" or "control"
(cherry picked from commit 6b88182)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 20ed0debe3e9d78a1feb3a75bf851393ca0aeb57
Author: Greg McCullough <[email protected]>
Date:   Thu Mar 30 09:22:45 2017 -0400

    Merge pull request #14519 from isimluk/rhbz#1435780
    
    Enforce policies type to be either "compliance" or "control"
    (cherry picked from commit 6b88182314fd5019bf52c2d9d85ef55364299b8b)

@jvlcek jvlcek mentioned this pull request Sep 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfu lfu lfu approved these changes

Assignees

@gmcculloug gmcculloug

Labels
core/policy enhancement fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@isimluk @gmcculloug @miq-bot @lfu @himdel @simaishi @chessbyte