Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inverse_of should be a symbol #14505

Merged
merged 1 commit into from
Mar 24, 2017
Merged

inverse_of should be a symbol #14505

merged 1 commit into from
Mar 24, 2017

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Mar 24, 2017 •
edited
Loading

Fix:

   1) EmsPhysicalInfraController#show shows associated datastores
     Failure/Error: has_one :host, inverse_of => :physical_server

     ActionView::Template::Error:
       undefined local variable or method `inverse_of' for #<Class:0x00557e928fdf70>

Introduced by #14026

@bdunne bdunne requested review from blomquisg and juliancheal March 24, 2017 18:44
@himdel
Copy link
Contributor

himdel commented Mar 24, 2017

Verified this fixes ui spec failures 👍

juliancheal
juliancheal reviewed Mar 24, 2017
View reviewed changes
Copy link
Member

@juliancheal juliancheal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@blomquisg
Copy link
Member

I'll close #14502

@blomquisg blomquisg mentioned this pull request Mar 24, 2017
Closed
@miq-bot
Copy link
Member

miq-bot commented Mar 24, 2017

Checked commit bdunne@40445e9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. ⭐

@bdunne
Copy link
Member Author

bdunne commented Mar 24, 2017

Looks like the Travis failures are all Openstack VCR unused interactions.

@blomquisg
Copy link
Member

This will help get UI green again.

@blomquisg blomquisg merged commit b697b6a into ManageIQ:master Mar 24, 2017
@blomquisg blomquisg added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 24, 2017
@bdunne bdunne deleted the inverse_of branch March 24, 2017 19:22
@Fryguy Fryguy mentioned this pull request Mar 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliancheal juliancheal juliancheal left review comments

@blomquisg blomquisg blomquisg approved these changes

Assignees

@blomquisg blomquisg

Labels
bug providers/physical
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bdunne @himdel @blomquisg @miq-bot @juliancheal