Eliminate Api::ServiceTemplateWorkflow service #14501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@imtayadeway I'm good with this. @mkanoor ok with making provision_workflow() public ? |
|
Forgot to add the mandatory 🔥 🔥 🔥 /cc @jrafanie |
|
as per @mkanoor #14481 will make that public. @imtayadeway see updated signature. Thanks. |
|
@abellotti cool 👍 I will wait until that gets merged then update. Marking as wip for now @miq-bot add-label wip |
imtayadeway
changed the title
✂️ 🔥 ✂️ 🔥 ✂️ 🔥 🍰 🍪 👏 🙇 😍 🎉 |
|
@imtayadeway |
imtayadeway
force-pushed
the
api/eliminate-service-template-workflow-service
branch
from
155b446 to
9335208
Compare
imtayadeway
changed the title
|
@miq-bot rm-label wip |
|
Checked commits imtayadeway/manageiq@c8a2a7d~...9335208 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Thanks @imtayadeway for making this update. 🎵 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its logic is now encapsulated in
ServiceTemplate#provision_workflowso this service can be removed.@mkanoor I had to make that method public in order for this to work. Is that OK?
Follow up to #13874
@miq-bot add-label api, refactoring
@miq-bot assign @abellotti