Link recently_discovered_pods widget to rpt

[kbrock]

Background

Widgets link to reports by report name.
This is because the ids in our database are not consistent across installs.
There is one widget that references a report by id.

Action

I updated the recently_discovered_pods widget to point to the report with the same name.

MiqReport.find_by(id: 198)
# => nil
MiqReport.find_by(name: "Recently Discovered Pods")
# => <MiqReport .....>

why do you think this is the right report?

1. There is only one report with a name like "recently discovered pods" (searched on like '%discovered%')
2. Most widgets have the report name the same or very similar to the widget name.

links

No BZ associated. I found while scanning through widget meta-data

/cc @nimrodshn FYI

[simon3z]

Thanks @kbrock makes perfect sense.
@nimrodshn did we introduce other of these? (We should fix them).

@kbrock I wonder if we should refuse to seed these in the database if they have an id (explicit ERROR), or if we should have a spec test over these yaml... these would catch future mistakes.

[nimrodshn]

@kbrock Good catch!
@simon3z After re-checking the PR it seems like this was my only buggy reference.

[kbrock]

ugh - bad push. trying to get green (think master is failing)

@nimrodshn to follow up on your comment. All the other reports you created were both good and consistent. So it took seconds to fix. (I'm trying to say thanks)

[miq-bot]

Checked commit kbrock@cfded78 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🍪

[Fryguy]

@kbrock Does this need to go to euwe?

[kbrock]

This was introduced in 12/6/2016 by #13055
If that is in euwe then we want to get this fix into that version.
UPDATE: No, this file is not in euwe - no need to backport
Note, there is no BZ for this PR (I stumbled upon this while parsing report files)