Set genealogy parent correctly to avoid multiple parents for graph refresh #14491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only by doing child.parent = parent, we enforce that there can be on 1 parent at the time.
Only by doing child.parent = parent, we enforce that there can be on 1 parent at the time.
Fryguy
approved these changes
Mar 24, 2017
|
@Ladas Is this for backport? or is this master only? |
|
@Fryguy should be only in Fine |
|
Checked commits Ladas/manageiq@3a6786a~...fedeaa5 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set genealogy parent correctly to avoid multiple parents for graph refresh
Only by doing child.parent = parent, we enforce that there can be on 1 parent at the time.
The hook variant is a slow n+1 for actual refresh, but it's used in some complex specs for graph refresh resolving cycles. The other is a custom saving code that does genealogy_parent assignment effectively and is currently used in AWS graph refresh.