Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove method MiqPolicy#action_result_for_event #14434

Merged
merged 1 commit into from
Mar 23, 2017

Conversation

jzigmund
Copy link

@jzigmund jzigmund commented Mar 21, 2017

Removing the method as we don't use it anymore - the last usage of the method was removed in ManageIQ/manageiq-ui-classic#754

Marking the PR as WIP - as we need to merge the PR from manageiq-ui-classic first.

@miq-bot miq-bot added the wip label Mar 21, 2017
@miq-bot
Copy link
Member

miq-bot commented Mar 21, 2017

Checked commit jzigmund@7a00aa3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 🍪

@martinpovolny martinpovolny self-assigned this Mar 22, 2017
@jzigmund jzigmund changed the title [WIP] Remove method MiqPolicy#action_result_for_event Remove method MiqPolicy#action_result_for_event Mar 23, 2017
@jzigmund
Copy link
Author

The PR from manageiq-ui-classic has been merged, removing WIP, please review

@miq-bot miq-bot removed the wip label Mar 23, 2017
Copy link
Member

@isimluk isimluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@isimluk isimluk added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 23, 2017
@isimluk isimluk assigned isimluk and unassigned martinpovolny Mar 23, 2017
@isimluk isimluk merged commit 12d7da9 into ManageIQ:master Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants