Remove MiqQueue rows containing a class removed in Rails 5. #14418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
force-pushed
the
remove_oid_integer_args_from_miq_queue
branch
from
e92e51f to
1569b51
Compare
|
@Fryguy Please review |
Fryguy
reviewed
Mar 20, 2017
| @@ -0,0 +1,8 @@ | |||
| class RemoveOidIntegerArgsFromMiqQueue < ActiveRecord::Migration[5.0] | |||
| class MiqQueue < ActiveRecord::Base; end | |||
| def change | |||
There was a problem hiding this comment.
This should be up migration only.
|
Also fix the rubocop...otherwise everything looks good 👍 |
|
Thanks, I'll fix this up and create a separate BZ for it. |
https://bugzilla.redhat.com/show_bug.cgi?id=1434454 The PostgreSQL::OID::Integer class was removed in: rails/rails@aafee23 It's possible that old Rails 4.2 versions of objects could have been serialized in the MiqQueue in the args column and we won't be able to deserialize them with Rails 5+, so we need to remove these rows. Related to ManageIQ#14365 Related to https://bugzilla.redhat.com/show_bug.cgi?id=1429747
jrafanie
force-pushed
the
remove_oid_integer_args_from_miq_queue
branch
from
1569b51 to
9795934
Compare
|
Checked commit jrafanie@9795934 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@Fryguy updated based on your feedback... I also created a different BZ and updated the commit and description. PTAL. Note, this is euwe/no |
Fryguy
approved these changes
Mar 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1434454
The PostgreSQL::OID::Integer class was removed in:
rails/rails@aafee23
It's possible that old Rails 4.2 versions of objects could have been
serialized in the MiqQueue in the args column and we won't be able to
deserialize them with Rails 5+, so we need to remove these rows.
Related to #14365
Related to https://bugzilla.redhat.com/show_bug.cgi?id=1429747