Delegate custom attributes to images in ChargebackContainerImage #14395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeari
force-pushed
the
delegate_custom_attributes_to_images
branch
2 times, most recently
from
e0ed308 to
2663497
Compare
zeari
force-pushed
the
delegate_custom_attributes_to_images
branch
from
2663497 to
b580851
Compare
… been set by the particular chargeback
|
Checked commit zeari@b580851 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@zeari This is good find. |
lpichler
approved these changes
Mar 20, 2017
There was a problem hiding this comment.
@isimluk @options[:groupby_tag].present? is always false for container images (there is no such option in UI) and then init_extra_fields(consumption) will init the entity as container image object - so we are using origin code for loading custom attributes
simaishi
pushed a commit
that referenced
this pull request
Mar 21, 2017
…ages Delegate custom attributes to images in ChargebackContainerImage (cherry picked from commit 6d5d478) https://bugzilla.redhat.com/show_bug.cgi?id=1434411
|
Euwe backport details: |
agrare
pushed a commit
to agrare/manageiq
that referenced
this pull request
Apr 19, 2017
…es_to_images Delegate custom attributes to images in ChargebackContainerImage (cherry picked from commit 6d5d478) https://bugzilla.redhat.com/show_bug.cgi?id=1434411
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1434159
Custom attributes in this report would
turn out nilcrash the report since they actually belong to the container image.@lpichler Please review
cc @simon3z
@miq-bot add_label bug, chargeback, providers/containers