Fix general CloudNetwork class_by_ems method #14392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks great 👍 |
blomquisg
reviewed
Mar 24, 2017
app/models/cloud_network.rb
Outdated
| @@ -41,11 +41,7 @@ class CloudNetwork < ApplicationRecord | |||
|
|
|||
| def self.class_by_ems(ext_management_system, external = false) | |||
There was a problem hiding this comment.
If external is now ignored here, can you change the parameter name here to _external?
tzumainn
force-pushed
the
cloud-network-class-by-ems-fix
branch
from
8b9c852 to
0336d72
Compare
|
@blomquisg made the change you suggested, thanks! |
|
Checked commit tzumainn@0336d72 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
blomquisg
approved these changes
Mar 24, 2017
|
@miq-bot merge when green /cc @chrisarcand |
|
@blomquisg Maybe I'd do it...if it were green... 😒👇 |
|
@Fryguy miq-bot was clearly hacked |
|
@miq-bot add_label euwe/yes |
simaishi
pushed a commit
that referenced
this pull request
Apr 13, 2017
Fix general CloudNetwork class_by_ems method (cherry picked from commit 30144fa) https://bugzilla.redhat.com/show_bug.cgi?id=1437148
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only OpenStack networks contain Public/Private versions, so class_by_ems will fail for other provider
cloud networks. This fix remediates that.
https://bugzilla.redhat.com/show_bug.cgi?id=1403152