Add openstack infra provider event blacklist #14369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit tzumainn@dc9110d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
blomquisg
reviewed
Mar 20, 2017
| @@ -64,6 +64,12 @@ def self.description | |||
| @description ||= "OpenStack Platform Director".freeze | |||
| end | |||
|
|
|||
| def self.default_blacklisted_event_names | |||
There was a problem hiding this comment.
@lfu weren't we capturing blacklisted events elsewhere?
We used to have a list of filtered event types. But, I don't know how that's done now.
There was a problem hiding this comment.
@blomquisg It used to be in config/event_handling.tmpl.yml. But this PR has moved them into DB.
Each provider model needs to maintain a list of the filtered events in default_blacklisted_event_names.
lfu
approved these changes
Mar 20, 2017
simaishi
pushed a commit
that referenced
this pull request
Apr 13, 2017
…klisted-events Add openstack infra provider event blacklist (cherry picked from commit 09eecb5) https://bugzilla.redhat.com/show_bug.cgi?id=1436237
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1422996