Add embedded_ansible to the list of roles that need apache #14353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We handle apache in a weird way. Rather than starting it when we need it, we always issue a restart when the server comes up (in MiqServer::EnvironmentManagement.prep_apache_proxying) but then shut it down if none of our active roles require it. That definition of requirement is governed by this array of roles so just adding the role name to the array will keep apache up if the role is active.
|
Checked commit carbonin@5a18a2e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We handle apache in a weird way.
Rather than starting it when we need it, we always issue a restart when the server comes up (in
MiqServer::EnvironmentManagement.prep_apache_proxying) but then shut it down if none of our active roles require it.That definition of requirement is governed by this array of roles so just adding the role name to the array will keep apache up if the role is active.