-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add job_plays to job #14331
Add job_plays to job #14331
Conversation
app/models/orchestration_stack.rb
Outdated
@@ -36,6 +36,7 @@ class OrchestrationStack < ApplicationRecord | |||
virtual_has_many :security_groups | |||
virtual_has_many :cloud_networks | |||
virtual_has_many :orchestration_stacks | |||
virtual_has_many :job_plays |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jntullo We should not need this relationship. Line 21 already has_many :resources
.
job_plays
make senses only when the object is ManageIQ::Providers::EmbeddedAnsible::AutomationManager::Job
which is a subclass of OrchestrationStack
. I don't know whether it is possible to for the API to add job_plays
at the job level.
Anyway, right now it is safe to assume all resources
are job_plays
, or the SUI can make an additional filtering resources
to limit to jobs only.
expose on the module
Checked commit jntullo@fd82107 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
@jntullo can you update the title of the PR? Then it is all good. |
@bzwei done 👍 |
@miq-bot assign @gmcculloug |
The Service UI needs to be able to retrieve
job_plays
from the newly added OrchestrationStacks subcollection (#14273)@miq-bot add_label enhancement, services
@miq-bot assign @bzwei