Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job_plays to job #14331

Merged
merged 1 commit into from
Mar 15, 2017
Merged

Add job_plays to job #14331

merged 1 commit into from
Mar 15, 2017

Conversation

jntullo
Copy link

@jntullo jntullo commented Mar 14, 2017

The Service UI needs to be able to retrieve job_plays from the newly added OrchestrationStacks subcollection (#14273)

@miq-bot add_label enhancement, services
@miq-bot assign @bzwei

@@ -36,6 +36,7 @@ class OrchestrationStack < ApplicationRecord
virtual_has_many :security_groups
virtual_has_many :cloud_networks
virtual_has_many :orchestration_stacks
virtual_has_many :job_plays
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jntullo We should not need this relationship. Line 21 already has_many :resources.
job_plays make senses only when the object is ManageIQ::Providers::EmbeddedAnsible::AutomationManager::Job which is a subclass of OrchestrationStack. I don't know whether it is possible to for the API to add job_plays at the job level.

Anyway, right now it is safe to assume all resources are job_plays, or the SUI can make an additional filtering resources to limit to jobs only.

@jntullo jntullo closed this Mar 14, 2017
@jntullo jntullo reopened this Mar 15, 2017
@miq-bot
Copy link
Member

miq-bot commented Mar 15, 2017

Checked commit jntullo@fd82107 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🏆

@bzwei
Copy link
Contributor

bzwei commented Mar 15, 2017

@jntullo can you update the title of the PR? Then it is all good.

@jntullo jntullo changed the title Add job_plays to orchestration_stack Add job_plays to job Mar 15, 2017
@jntullo
Copy link
Author

jntullo commented Mar 15, 2017

@bzwei done 👍

@bzwei
Copy link
Contributor

bzwei commented Mar 15, 2017

@miq-bot assign @gmcculloug

@miq-bot miq-bot assigned gmcculloug and unassigned bzwei Mar 15, 2017
@gmcculloug gmcculloug merged commit b9c1057 into ManageIQ:master Mar 15, 2017
@gmcculloug gmcculloug added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 15, 2017
@jntullo jntullo deleted the enhancement/expose_job_plays branch November 28, 2017 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants