-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miq Alert Status model changes for resolved alerts #14295
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
class AddResolvedToAlerts < ActiveRecord::Migration[5.0] | ||
def change | ||
add_column :miq_alert_statuses, :resolved, :boolean | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. think we want to populate in a data migration There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We do not need that since resolved alerts are only used in the datawarehouse provider which is prototype and hidden in the product. Also resolved alerts are not yet collected (that pr is being reviewed as well #14299) |
||
end | ||
end |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
class AddAlertEmsRef < ActiveRecord::Migration[5.0] | ||
def change | ||
add_column :miq_alert_statuses, :event_ems_ref, :string | ||
add_index :miq_alert_statuses, :event_ems_ref | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this ems_ref related to the manageiq events table at all? If not, then this name might be confusing. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Or I can just read back in the thread 😄 |
||
end | ||
end |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
class RemoveAncestryFromAlerts < ActiveRecord::Migration[5.0] | ||
def change | ||
remove_index :miq_alert_statuses, :ancestry | ||
remove_column :miq_alert_statuses, :ancestry, :string | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay!