Set timeout for inventory refresh calls

[masayag]

The settings.yml contains timeout only for RHV service calls. However
when services are invoked as part of the refresh process, no timeout
is provided for these calls, letting the Net::HTTP 60 seconds default
timeout to be the affective timeout.

The 60 seconds default timeout is too short, therefore the default
timeout for inventory service calls to RHV is set to 1 hour.

http://bugzilla.redhat.com/1430722

[miq-bot]

Checked commit masayag@5565e5a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 👍

[masayag]

@miq-bot add_label blocker, euwe/yes, providers/rhevm

[masayag]

@miq-bot assign @borod108

[durandom]

Wow, nasty bug @masayag

here this option gets set

[durandom]

@oourfali wdyt regarding docs? I think new options should also have new docs :)

[borod108]

LGTM.

[durandom]

@miq-bot assign @agrare

@agrare pls merge

[agrare]

@masayag is this timeout per API call? 1 hour seems like a very long time for an API call

[masayag]

@agrare This timeout is per API call, same timeout is set for the :service (which is an explicit call for the API not as part of the refresh).

We hit that on a setup which had a slow network, where a request for all of the vms took over 10 minutes.
I wouldn't expect to hit timeout in any part of the refresh process. I assume that after the first timeout the PartialRefreshException will be thrown and the refresh process will be terminated due to that timeout.

[agrare]

Makes sense to have the same timeout as the other service, but if you need a 1hr timeout per API call I think we're going to have bigger problems haha

[simaishi]

Euwe backport details:

$ git log -1
commit 2b87bd1158d4148e6ed69642b1a63bbed37bcb32
Author: Adam Grare <[email protected]>
Date:   Fri Mar 10 09:21:49 2017 -0500

    Merge pull request #14245 from masayag/rhv_inventory_timeout
    
    Set timeout for inventory refresh calls
    (cherry picked from commit 0a7255b7ae6e3e94925173931466078b3da09e61)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1431620