Fix for Service Dialog not saving default value <None> for drop down or radio button #14240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eclarizio
force-pushed
the
BZ1428133
branch
2 times, most recently
from
20c839e to
0227e27
Compare
gmcculloug
reviewed
Mar 9, 2017
| def raw_values | ||
| @raw_values ||= dynamic ? values_from_automate : static_raw_values | ||
|
|
||
| self.value ||= default_value if @raw_values.collect { |value_pair| value_pair[0] }.include?(default_value) |
There was a problem hiding this comment.
@eclarizio Would suggest pulling this logic out into a separate private method with a descriptive name. Would make the raw_values method easier to read and make the logic of this line clearer as well.
gmcculloug
reviewed
Mar 9, 2017
syncrou
reviewed
Mar 9, 2017
| @@ -91,7 +91,7 @@ def sort_data(data_to_sort) | |||
| end | |||
|
|
|||
| def raw_values | |||
| @raw_values ||= dynamic ? values_from_automate : self[:values].to_miq_a | |||
| @raw_values ||= dynamic ? values_from_automate : static_raw_values | |||
| unless @raw_values.collect { |value_pair| value_pair[0] }.include?(default_value) | |||
There was a problem hiding this comment.
@eclarizio - I would second @gmcculloug - Can we extract this out into a private method as well - I'm getting lost in what the block is trying to accomplish.
|
Checked commits eclarizio/manageiq@c1a02a6~...d530fb7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
eclarizio
pushed a commit
to eclarizio/manageiq
that referenced
this pull request
Mar 9, 2017
Fix for Service Dialog not saving default value <None> for drop down or radio button (cherry-picked from commit a912f50) https://bugzilla.redhat.com/show_bug.cgi?id=1428133
|
Backported to Euwe via #14259 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow nil to be a default value for static sorted item fields. When the field is required, the user will be able to pick a "" options which corresponds to the nil option, and a "" option otherwise.
https://bugzilla.redhat.com/show_bug.cgi?id=1428133
/cc @gmcculloug Please review/test
@miq-bot assign @gmcculloug
@miq-bot add_label bug, euwe/yes