Avoid calling $evm.backtrace over DRb to prevent DRb-level mutex locks #14239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
force-pushed
the
remove_backtrace_over_drb
branch
from
736e478 to
2b75b68
Compare
|
Found a bug in the actual line count...need to write a test for it :) |
Fryguy
force-pushed
the
remove_backtrace_over_drb
branch
3 times, most recently
from
bb63a49 to
3a8e356
Compare
Fryguy
changed the title
|
In review with @mkanoor we found that nested methods will only have the first method's name because of where I put the method_name hook. So marking as WIP til I fix that. |
Fryguy
changed the title
Fryguy
force-pushed
the
remove_backtrace_over_drb
branch
from
3a8e356 to
7325485
Compare
Fryguy
changed the title
Moves dynamic method building into DrbRemoteInvoker since it isn't needed at all in MiqAeService. Once in DrbRemoteInvoker, we can use the dynamic preamble to inform the generated ruby method body of things like the number of preamble lines and the name of the method for backtrace filtering purposes.
Fryguy
force-pushed
the
remove_backtrace_over_drb
branch
from
7325485 to
083117c
Compare
|
Some comments on commits Fryguy/manageiq@1e30d48~...083117c spec/lib/miq_automation_engine/engine/miq_ae_method_spec.rb
|
|
Checked commits Fryguy/manageiq@1e30d48~...083117c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Merging, @mkanoor gave verbal approval to this change yesterday 👍 |
|
👍 |
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Mar 29, 2018
We previously tried to upgrade to 2.3.6 on euwe by backporting: ManageIQ#15993 This was causing a hang in the automation test suite on euwe and we reverted it in: ManageIQ#16087 https://bugzilla.redhat.com/show_bug.cgi?id=1560578 The prior 2 commits contain a manual backport of ManageIQ#14239 which solves the 100% cpu hang of the automate ruby method with ruby 2.3.2+.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves dynamic method building into DrbRemoteInvoker since it isn't
needed at all in MiqAeService. Once in DrbRemoteInvoker, we can use
the dynamic preamble to inform the generated ruby method body of things
like the number of preamble lines and the name of the method for
backtrace filtering purposes.
Note, moving this method into
DrbRemoteInvokerallows us to run it in the launched automate ruby process directly and not over DRb. The latter was causing random DRb thread issues when the ruby method exited or raised an exception.@mkanoor Please review
Paired with @jrafanie on this one, which he originally noticed in #13104 .