-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend container service model #14233
Extend container service model #14233
Conversation
@kevensen can you review? IIRC this should be related to something you did recently. |
@simon3z Indeed it is. LGTM. |
OK, LGTM 👍 @gmcculloug are these helping @bzwei for his template provisioning? Should he review this? |
expose :container_template_parameters, :association => true | ||
expose :ext_management_system, :association => true | ||
expose :is_tagged_with? | ||
expose :tags |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized these tag methods got into a lot of the container models, but they need to be removed. You should be using the tag methods defined for at the base service model level here:
https://github.com/ManageIQ/manageiq/blob/master/lib/miq_automation_engine/engine/miq_ae_method_service/miq_ae_service_model_base.rb#L218
Will need to open a git issue to clean up the other service models that added these methods:
miq_ae_service_container.rb
miq_ae_service_container_build.rb
miq_ae_service_container_build_pod.rb
miq_ae_service_container_deployment_node.rb
miq_ae_service_container_group.rb
miq_ae_service_container_image.rb
miq_ae_service_container_image_registry.rb
miq_ae_service_container_node.rb
miq_ae_service_container_replicator.rb
miq_ae_service_container_route.rb
miq_ae_service_container_service.rb
miq_ae_service_container_volume.rb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tag methods removed.
Checked commits supernoodz/manageiq@c5ca4ea~...10682a3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Extend container service model (cherry picked from commit 9851870) https://bugzilla.redhat.com/show_bug.cgi?id=1444494
Euwe backport details:
|
Add useful container service model associations for use in Automate: