Require EmbeddedAnsible playbook to create playbook service #14226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label providers/ansible_tower |
|
@syncrou please review |
|
Checked commit bzwei@8ea1f8d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Looks good. Was running with configuration locally as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we assume the playbook to create a playbook catalog item is of type
ManageIQ::Providers::AnsibleTower::AutomationManager::Playbook. Now we need to switch toManageIQ::Providers::EmbeddedAnsible::AutomationManager::PlaybookWe can argue whether it is better to write
playbook = ConfigurationScriptBase.find(info[:playbook_id])which will work for both Embedded and external playbook. I think right now limiting to Embedded only can help to reject unqualified ConfigurationScript. We can further enhance when the time comes to support external tower.