Move the call to reload ntp settings to the server only #14208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when the ntp settings were changed every worker would enqueue a message for the server to reload the settings when they went through the Config::Activator. Multiple calls to restart chronyd within a matter of seconds causes systemd to backoff and fail the unit causing chronyd not to run until the appliance is rebooted or it is started manually. This change makes the server reload the ntp settings every time its config is changed, but removes the call to reload from the activator which removes all the calls generated when the workers refresh their settings. This results in just one call to reload the settings when the config is changed rather than tens.
|
Checked commit carbonin@939524f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Mar 7, 2017
Move the call to reload ntp settings to the server only (cherry picked from commit 515b4a0) https://bugzilla.redhat.com/show_bug.cgi?id=1429999
|
Euwe backport details: |
jrafanie
reviewed
Mar 7, 2017
agrare
pushed a commit
to agrare/manageiq
that referenced
this pull request
Apr 19, 2017
Move the call to reload ntp settings to the server only (cherry picked from commit 515b4a0) https://bugzilla.redhat.com/show_bug.cgi?id=1429999
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the ntp settings were changed every worker would enqueue a message for the server to reload the settings when they went through the Config::Activator.
Multiple calls to restart chronyd within a matter of seconds causes systemd to back off and fail the unit causing chronyd not to run until the appliance is rebooted or it is started manually.
This change makes the server reload the ntp settings every time its config is changed, but removes the call to reload from the activator which removes all the calls generated when the workers refresh their settings. This results in just one call to reload the settings when the config is changed rather than tens.
https://bugzilla.redhat.com/show_bug.cgi?id=1429714