Create a CustomAttribute for VmOrTemplate labels. #14202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label enhancement |
|
Checked commit bronaghs@a17bb3b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
blomquisg
reviewed
Mar 7, 2017
| @@ -128,6 +128,7 @@ class VmOrTemplate < ApplicationRecord | |||
| has_many :direct_services, :through => :service_resources, :source => :service | |||
| belongs_to :tenant | |||
| has_many :connected_shares, -> { where(:resource_type => "VmOrTemplate") }, :foreign_key => :resource_id, :class_name => "Share" | |||
| has_many :labels, -> { where(:section => "labels") }, :class_name => "CustomAttribute", :as => :resource, :dependent => :destroy | |||
There was a problem hiding this comment.
@Fryguy "naming is hard" ... At first glance, I was fine with labels, but then I'm not sure if this should be provider_labels, or something indicating that these labels are imported directly from the provider.
Any thoughts here?
|
cc @AparnaKarve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS labels (or potentially any provider's labels ) are gathered and stored as Custom Attributes in the database. They will be displayed in the Summary pages of the UI in the Labels table
This PR takes care of the model changes for this feature. Currently, only AWS VMs and images support tags.
The
save_labels_inventoryandsave_custom_attribute_attribute_inventorymethods should be moved out of thesave_inventory_containersclass and into a generic class but since the dev freeze is 2 weeks away this will have to be done in a separate PRPivotal story: https://www.pivotaltracker.com/story/show/139414085