[EUWE] Resolve oVirt IP addresses (backport of ManageIQ/manageiq#13767) #14183
Conversation
|
@simaishi Please don't merge yet, as I still need to verify that it works correctly in the Euwe branch. I will let you know when it is verified. |
miq-bot
changed the title
|
@durandom who can merge this one? Shall we re-trigger CI? |
|
@jhernand were you able to verify it works? |
|
The Travis failures seem unrelated to me. I will close and re-open to trigger Travis again. I will complete the verification today. |
|
I have verified that this works correctly. However there are now Travis failures that seem related. I am working on that, so please don't merge yet. |
Since version 4 oVirt rejects connections that use directly the IP
address instead of the host name. This is a side effect of the new SSO
authentication mechanism. That means that when a oVirt provider is added
using an IP address it will not work. Users don't do this frequently,
but the system does it automatically when the provider is added using
the discovery mechanism, as this mechanism uses IP addresses only. To
avoid this issue this patch changes the provider so that when it
receives an IP address it tries to convert it to the corresponding fully
qualified host name.
There may be situations where the user really wants to use an IP
address, and not the host name. For those cases this patch also
introduces a new 'resolve_ip_addresses' setting that can be used to
disable resolving. This setting will be stored in the
'config/settings.yml' file, and its default value will be 'true':
:ems:
:ems_redhat:
:resolve_ip_addresses: true
https://bugzilla.redhat.com/1417757
|
Checked commit https://github.com/jhernand/manageiq/commit/0b2157c0e6dd7d9098182ec2b7a52e802deb3985 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@simaishi I have addressed all the test issues that are related to the patch, and rebased to use latest tip of the Euwe branch, but there are still Travis build failures. To verify that they aren't related I ran the tests in my own clone of the repository, without my changes, and it is also failing: https://travis-ci.org/jhernand/manageiq/jobs/208505484 Do you have any suggestion on how to move forward? |
|
@jhernand The travis failures in Euwe are currently being worked on. I'll re-run the job once they're fixed, so no need to worry about them for now. |
|
Great, thanks @simaishi. |
|
@blomquisg @durandom is this good to go? |
|
Correct @durandom, the only changes are in the specs. In the master branch the specs for the refresh of version 3.0 of oVirt have been removed, and the rest of them have been moved to a |
|
@jhernand here is fine. If somebody wonders he'll end up here too... thanks |
This is a back-port of #13767.
Since version 4 oVirt rejects connections that use directly the IP
address instead of the host name. This is a side effect of the new SSO
authentication mechanism. That means that when a oVirt provider is added
using an IP address it will not work. Users don't do this frequently,
but the system does it automatically when the provider is added using
the discovery mechanism, as this mechanism uses IP addresses only. To
avoid this issue this patch changes the provider so that when it
receives an IP address it tries to convert it to the corresponding fully
qualified host name.
There may be situations where the user really wants to use an IP
address, and not the host name. For those cases this patch also
introduces a new
resolve_ip_addressessetting that can be used todisable resolving. This setting will be stored in the
config/settings.ymlfile, and its default value will be 'true':https://bugzilla.redhat.com/1417757