Do not pass the same argument twice #14158
Conversation
|
Checked commit moolitayer@6b25bec with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
| cb = { | ||
| :class_name => self.class.to_s, | ||
| :instance_id => id, | ||
| :method_name => :check_policy_prevent_callback, | ||
| :args => [*cb_method], | ||
| :args => [cb_method, event_target], |
There was a problem hiding this comment.
@moolitayer I'm assuming that event_target is an object (which is good)
But this is also putting the object into the queue. (which is bad)
Please change the :args to have the class and id.
And please change check_policy_prevent_callback to take arguments with a class and id.
There was a problem hiding this comment.
ok, this is being fixed in another pr
The purpose is to fix a) ( |
| cb = { | ||
| :class_name => self.class.to_s, | ||
| :instance_id => id, | ||
| :method_name => :check_policy_prevent_callback, | ||
| :args => [*cb_method], | ||
| :args => [cb_method, event_target], |
There was a problem hiding this comment.
ok, this is being fixed in another pr
|
Thanks for taking the time to review @kbrock |
Simplify function call