Move the previously refactored provider mixin into the shared directory #14152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously moved out into a mixin in ManageIQ#13733, but probably belongs with the other things in the shared namespace that was created in ManageIQ#14074
|
Checked commit carbonin@3e6bd52 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Ping @blomquisg @jameswnl Does this make sense? I'm planning on building on this in a follow-up for creating some MIQ-specific default objects in the provider at startup. Just wanted to make sure I was on the right track. |
|
It makes sense to me! It will be consistent with the |
|
nice @carbonin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously moved out into a mixin in #13733, but probably belongs with the other things in the shared namespace that was created in #14074