Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Container Administrator and Operator roles #14137

Merged
merged 1 commit into from
Apr 18, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 89 additions & 0 deletions db/fixtures/miq_user_roles.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1142,3 +1142,92 @@
- dashboard
- chargeback
- miq_report

- :name: EvmRole-container_administrator
:read_only: true
:miq_product_feature_identifiers:
- vms_filter_accord
- instances_filter_accord
- datacenter_controller
- storage_pod
- dashboard
- miq_report
- consumption
- chargeback
- pictures
- control_explorer
- generic_object_explorer
- my_settings
- tasks
- about
- ontap_storage_system
- ontap_storage_volume
- ontap_logical_disk
- cim_base_storage_extent
- ontap_file_share
- snia_local_file_system
- storage_manager
- ems_container
- middleware_server_group
- container_group
- container_node
- container_replicator
- container_image
- container_image_registry
- persistent_volume
- container_build
- container_template
- container_service
- container_route
- container_project
- containers
- container_topology
- container_dashboard
- ems_infra_dashboard
- instance_view
- vm_view
- miq_cloud_networks
- miq_arbitration_settings
- miq_arbitration_rules
- blueprint
- redhat_access_insights_admin
- ems_container_ad_hoc_metrics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ems_container_ad_hoc_metrics is missing from @Loicavenel's description but I think it makes sense here (it was introduced after Euwe).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is correct (it was also mentioned in the docs)



- :name: EvmRole-container_operator
:read_only: true
:miq_product_feature_identifiers:
- vms_filter_accord
- instances_filter_accord
- dashboard_view
- miq_report_saved_reports_view
- miq_report_view
- miq_report_control
- chargeback_reports
- my_settings
- tasks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tasks is missing from @Loicavenel's description but I think it makes sense here.

- ems_container_view
- ems_container_check_compliance
- container_group_view
- container_group_check_compliance
- container_node_view
- container_node_check_compliance
- container_replicator_check_compliance
- container_image_view
- container_image_scan
- container_image_check_compliance
- container_image_registry_view
- persistent_volume_view
- container_build_view
- container_template_view
- container_service_view
- container_route_view
- container_project_view
- container_filter_accord
- container_view
- container_control
- container_topology
- container_dashboard
- instance_view
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @Loicavenel also had image_view, should we add it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think it was a mistake: he had image_view instead of instance_view

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zakiva @Loicavenel had both image_view and instance_view IIRC.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Loicavenel IIRC when we discussed it you confirmed that we need instance_view and not image_view, is that right?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is correct.. but don't get confused, I am talking about image view from Cloud not from container..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Loicavenel sure, for container image we have all the features above

- vm_view
- ems_container_ad_hoc_metrics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ems_container_ad_hoc_metrics is missing from @Loicavenel's description but I think it makes sense here (it was introduced after Euwe).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simon3z I am good here..

2 changes: 2 additions & 0 deletions db/fixtures/role_map.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,5 @@
EvmGroup-tenant_administrator: tenant_administrator
EvmGroup-tenant_quota_administrator: tenant_quota_administrator
EvmGroup-consumption_administrator: consumption_administrator
EvmGroup-container_administrator: container_administrator
EvmGroup-container_operator: container_operator
2 changes: 1 addition & 1 deletion spec/models/miq_user_role_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
describe MiqUserRole do
before do
@expected_user_role_count = 15
@expected_user_role_count = 17
end

context ".seed" do
Expand Down