Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposing regions as a primary collection /api/regions #14109

Merged
merged 2 commits into from
Mar 7, 2017
Merged

Exposing regions as a primary collection /api/regions #14109

merged 2 commits into from
Mar 7, 2017

Conversation

abellotti
Copy link
Member

  • /api/regions
  • Support queries of /api/regions
  • Support "query" post for bulk queries

@abellotti
Copy link
Member Author

abellotti commented Feb 28, 2017 •
edited
Loading

This is a precursor for the settings support enhancements.

WIP, missing:

  • identifiers
  • rspecs

@abellotti
Copy link
Member Author

abellotti commented Mar 2, 2017 •
edited
Loading

@imtayadeway please review

/cc @h-kataria for the miq_product_features changes, thanks!

@abellotti abellotti removed the wip label Mar 2, 2017
@abellotti abellotti changed the title [WIP] Exposing regions as a primary collection /api/regions Exposing regions as a primary collection /api/regions Mar 2, 2017
imtayadeway
imtayadeway reviewed Mar 3, 2017
View reviewed changes
config/api.yml
:identifier: region
:options:
- :collection
:verbs: *gp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're adding post, can one update a region with the default implementation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not today. This post is just for the bulk query implemented.

But shortly, it will also be used for updating settings.

@abellotti abellotti mentioned this pull request Mar 3, 2017
Merged
@abellotti
Copy link
Member Author

ping @imtayadeway @h-kataria any changes needed here ?

@imtayadeway
Copy link
Contributor

@abellotti could you add a test to prove that the code added for region member GETs is needed/works?

Otherwise LGTM

abellotti added 2 commits March 6, 2017 12:48
@abellotti
Exposing regions as a primary collection /api/regions
65f703f 
- /api/regions
- Enhanced miq_product_features to support Region queries/edits
- Support queries of /api/regions
- Support "query" post for bulk queries
@abellotti
Adding regions resource specs.
4f674d3
@abellotti
Copy link
Member Author

Thanks @imtayadeway !! regions resources spec added.

@miq-bot
Copy link
Member

miq-bot commented Mar 6, 2017

Checked commits abellotti/manageiq@65f703f~...4f674d3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks good. 🍰

h-kataria
h-kataria approved these changes Mar 7, 2017
View reviewed changes
Copy link
Contributor

@h-kataria h-kataria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

product features changes look good

@abellotti
Copy link
Member Author

Thanks @h-kataria for the review

gtanzillo
gtanzillo approved these changes Mar 7, 2017
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@gtanzillo gtanzillo added this to the Sprint 56 Ending Mar 13, 2017 milestone Mar 7, 2017
@gtanzillo gtanzillo merged commit cf439c2 into ManageIQ:master Mar 7, 2017
@abellotti abellotti deleted the api_region branch March 8, 2017 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-kataria h-kataria h-kataria approved these changes

@imtayadeway imtayadeway imtayadeway approved these changes

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@gtanzillo gtanzillo

Labels
api enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abellotti @imtayadeway @miq-bot @gtanzillo @h-kataria