-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remote servers to rake evm:status_full #14107
Add remote servers to rake evm:status_full #14107
Conversation
Added server id to the workers status to line up workers more easily with the servers they're running on.
Naming is hard.
a60e743
to
f9fe840
Compare
@carbonin @gtanzillo @Fryguy Please review |
Checked commits jrafanie/manageiq@3a04d34~...f9fe840 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I would look into the possible effects of changing the output of the evm:status
command though. I remember seeing someone somewhere parsing the output of this.
Also, with this type of diagnosis in mind, do we want to replicate assigned_server_roles
? Does anyone remember the reason for excluding that table?
Gah sorry @carbonin . My page was stale and I didn't see your comment until after I merged 😕 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! @jrafanie 👍
Good point @carbonin, I'll ping Brad to make sure the field knows about this PR and perhaps they can offer suggestions to keep the output easy for them to parse.
EDIT: Same for miq_workers... it looks like those are NOT replicated... I don't know that we need them centrally but perhaps it would be nice run this script centrally to get a good high level overview of the application, regions, zones, servers, workers, roles, etc. |
This PR adds a new rake task,
evm:status_full
, that prints the local server and remote servers and their workers ordered by server and zone.I also added:
is_master
column to the server outputmiq_server_id
column to the worker outputI'm not in love with the rake task name or if this should replace
evm:status
or be a new rake task.Here is what it look like using a sanitized central database (with multiple regions):