Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not truncate(255) message attribute in miq_tasks table #14105

Conversation

yrudman
Copy link
Contributor

@yrudman yrudman commented Feb 28, 2017

After linking jobs and miq_tasks tables, message attribute from jobs table propagated to miq_tasks.message (PR: #13452).
We do not need to truncate message since data type of miq_tasks.message is text (PR: #14100)

this PR depends on #14100

@miq-bot add-label bug, core

\cc @Fryguy

…ing jobs amd miq_tasks table, data type of message attribute is text (the same as message attribute on jobs table)
…tasks.message since datatype was changed to text
@miq-bot
Copy link
Member

miq-bot commented Feb 28, 2017

Checked commits yrudman/manageiq@254b535~...9bea373 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 0 offenses detected
Everything looks good. 👍

@Fryguy Fryguy merged commit aa01358 into ManageIQ:master Mar 1, 2017
@Fryguy Fryguy added this to the Sprint 56 Ending Mar 13, 2017 milestone Mar 1, 2017
@Fryguy Fryguy self-assigned this Mar 1, 2017
@yrudman yrudman deleted the do-not-truncate-message-attribute-in-miq-tasks-table branch March 1, 2017 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants