Return result of destroy action to user, not nil

[isimluk]

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1414881

The cause of the bug was, that delete_resource action must return action-result-hash and this was returning nil.

@miq-bot add_label bug, euwe/yes, api
@miq-bot assign @abellotti

[chessbyte]

@isimluk Any way to write a test validating that destroy only gets called once? It would then fail before this PR and succeed with it.

[Ladas]

+1

@isimluk I am glad I could help. :-)

although the hook seems to be conditional https://github.com/Ladas/manageiq/blob/cdc6c6319475c225cf0e5b970298c8a5a6bf8d29/app/models/orchestration_template_vnfd.rb#L6-L6 so it should not fire, unless you change the condition?

[isimluk]

Good food for thoughts.

This will need to have some work on remote_proxy thing.

@miq-bot add_label wip

[isimluk]

@abellotti, I have run into a dead end with #14266, so I changed this pr to just fix the bug. It is now ready for review. Thanks!

[miq-bot]

Some comments on commits isimluk/manageiq@96e621c~...5af77c5

spec/requests/api/orchestration_template_spec.rb

• ⚠️ - 120 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

[miq-bot]

Checked commits isimluk/manageiq@96e621c~...5af77c5 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 🏆

[abellotti]

That fix looks right. Is this euwe/yes still ? if so does it depend on other PRs and have those been euwe/yes. Thanks.

[Ladas]

looks great 👍

[isimluk]

Is this euwe/yes still ?

Yes.

if so does it depend on other PRs and have those been euwe/yes.

Unfortunately, no. Dust settles on the other parts of the code.

[abellotti]

Thanks @isimluk 👍

[simaishi]

Euwe backport details:

$ git log -1
commit 9608b9009e5306ede9b6862abba3eee681b02f83
Author: Alberto Bellotti <[email protected]>
Date:   Tue Mar 21 15:03:23 2017 -0400

    Merge pull request #14097 from isimluk/rhbz#1414881
    
    Return result of destroy action to user, not nil
    (cherry picked from commit 9aa0cfe1ea89a277b7cf28efe0024ee21a0d3b3c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1434952