Enable operations on CloudObjectStoreObject #14080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miha-plesko looks like you have to update schema.yml too |
miha-plesko
force-pushed
the
delete_aws_object
branch
2 times, most recently
from
7714391 to
7ff7812
Compare
kbrock
reviewed
Feb 27, 2017
| def change | ||
| add_column :cloud_object_store_objects, :type, :string | ||
| add_index :cloud_object_store_objects, :type | ||
| add_index :cloud_object_store_objects, [:ems_id, :type] |
There was a problem hiding this comment.
Thanks for the index.
Please drop the :type index and swap the order of this index
add_index :cloud_object_store_objects, [:type, :ems_id]
miha-plesko
force-pushed
the
delete_aws_object
branch
from
7ff7812 to
ae55f85
Compare
This was referenced Feb 27, 2017
miha-plesko
force-pushed
the
delete_aws_object
branch
4 times, most recently
from
29b3dc0 to
64e8b32
Compare
This commit brings support for operations on CloudObjectStoreObject. For now, only delete operation is supported. Signed-off-by: Miha Pleško <[email protected]>
miha-plesko
force-pushed
the
delete_aws_object
branch
from
64e8b32 to
81072db
Compare
|
Checked commit xlab-si@81072db with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
h-kataria
added a commit
to h-kataria/manageiq
that referenced
this pull request
Oct 3, 2017
supports_not for delete was added for these objects in ManageIQ#14080 however same PR added "Delete" roles feature. "Delete" button was added to UI counterpart of this PR in ManageIQ/manageiq-ui-classic#497, so in my opinion adding supports_not for delete was incorrect https://bugzilla.redhat.com/show_bug.cgi?id=1497113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit brings support for operations on CloudObjectStoreObject. For now, only delete operation is supported. The two new columns
typeandnamehave to be there to enable appropriate async task processing.