Ignore custom attributes that have a nil name #14055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where building reportable fields from custom attributes blows up when the name is nil. https://bugzilla.redhat.com/show_bug.cgi?id=1426029
gtanzillo
force-pushed
the
bz-1426029-nil-custom-attr
branch
from
0a1d7c5 to
b18c510
Compare
|
Checked commit gtanzillo@b18c510 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
jrafanie
approved these changes
Feb 23, 2017
There was a problem hiding this comment.
As we discussed with @agrare, it makes sense to try to figure out and fix anything inserting nil names in the custom attributes but since we don't validate the name, we should probably not blow up if a nil name custom attribute makes it in the system. 👍
simaishi
pushed a commit
that referenced
this pull request
Feb 23, 2017
Ignore custom attributes that have a nil name (cherry picked from commit 9fd7e20) https://bugzilla.redhat.com/show_bug.cgi?id=1426433
|
Euwe backport details: |
agrare
pushed a commit
to agrare/manageiq
that referenced
this pull request
Apr 19, 2017
…m-attr Ignore custom attributes that have a nil name (cherry picked from commit 9fd7e20) https://bugzilla.redhat.com/show_bug.cgi?id=1426433
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where building reportable fields from custom attributes blows up when the name is nil.
https://bugzilla.redhat.com/show_bug.cgi?id=1426029
/cc @Fryguy @jrafanie @lpichler