Adding Firmwares migration #14025
Merged
Adding Firmwares migration #14025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliancheal
changed the title
|
@juliancheal Cannot apply the following label because they are not recognized: sql migrations |
|
@miq-bot add_label sql migration |
juliancheal
force-pushed
the
add_firmwares_migration
branch
from
920bcbf to
2e93737
Compare
This was referenced Feb 22, 2017
Closed
|
@miq-bot remove_label wip |
The rational for this is that many hardware types require firmware metadata. For example, physical_server (via guest_device), disks, switches, etc. Firmware is polymorphic so that we can ask questions like, Give me all the firmwares of type x that are running non-compliant firmware. We tried to fit firmware into Operating System, or as extra fields on Guest Device, but it feels like it should be its own thing.
juliancheal
force-pushed
the
add_firmwares_migration
branch
from
2e93737 to
016fe61
Compare
|
@Fryguy could you review this? |
juliancheal
force-pushed
the
add_firmwares_migration
branch
from
955f10e to
0a4459b
Compare
Fryguy
reviewed
Mar 10, 2017
| t.bigint :resource_id | ||
| t.string :resource_type | ||
| t.timestamps | ||
| t.index %w(resource_id resource_type), :name => "index_firmwares_on_resource_id_and_resource_type", :using => :btree |
There was a problem hiding this comment.
I think the :using piece is not necessary as that's the default. Curious why you need the name either. If that's the default, cause you remove that as well?
|
@Fryguy removed params on index. |
juliancheal
force-pushed
the
add_firmwares_migration
branch
from
3bb0e15 to
f2cb5b0
Compare
|
Checked commits juliancheal/manageiq@016fe61~...f2cb5b0 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@juliancheal @Fryguy, is this good to go? |
|
@sergio-ocon for me I believe so yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rational for this is that many hardware types require firmware
metadata. For example,
physical_server(viaguest_device),disks,switches, etc.Firmware is polymorphic so that we can ask questions like,
Give me all the firmwares of type x that are running non-compliant
firmware.
We tried to fit firmware into
Operating System, or as extra fieldson
Guest Device, but it feels like it should be its own thing.