Scanning for used attributes for query optimizations #14023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kbrock first step for tracking attribute references, it's not used now to |
|
This pull request is not mergeable. Please rebase and repush. |
We want to allow setting references as public
The constant is written as O(1) not O(C)
Calling .include? on Set is O(1)
Not relevant comment, attributes is callable multiple times now
Add ApplicationRecordLite that is for holding is and class of AR. ActiveRecord object are to huge and we need a query to obtain them, in most cases we have a class and id, which is just enough to fil la relation. No need to go to db.
Collect attribute_references and use them for db strategy. So we are able to load a relation fro ma db without making a sql query, wrapping it to ApplicationRecordLite.
Extract InitDataHelper so it's reusable in other specs
Spec testing a db_find_strategy with :key poiting to relation
Ladas
force-pushed
the
scanning_for_used_attributes_for_query_optimizations
branch
from
a07cb9d to
0eaa8a3
Compare
Ladas
changed the title
Autofix rubocop issues
Fix a polymorphic relation loading
Test a polymorphic relation is obtained via :key
Clean up a spec to only use a needed ICs
Look for foreign_key only in belongs_to relations, we would get a confusing trying to assign to another relation.
Check for allowed strategies and raise exception with a list of allowed
A complex interconnection spec
Enhance specs and run them for both DB strategies
Autofix rubocop issues
kbrock
approved these changes
Feb 23, 2017
Rename ApplicationRecordLite to ApplicationRecordReference, as it shows the purpose much better.
|
Checked commits Ladas/manageiq@d9be0c2~...19e7dcc with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 spec/models/manager_refresh/save_inventory/strategies_and_references_spec.rb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scans for AR attributes referred by :key and uses that to populate a a DB loaded InventoryCollection. + Specs
Partially implements:
https://www.pivotaltracker.com/story/show/138129875
We first need solid specs, before the optimizattions