Core changes for Ansible Credentials UI #14020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzazrivec
force-pushed
the
core_changes_for_ansible_credentials
branch
from
5ea4724 to
1aa9ff1
Compare
mzazrivec
changed the title
|
This pull request is not mergeable. Please rebase and repush. |
|
@dclarizio Cannot apply the following label because they are not recognized: enhancement ui |
|
@miq-bot add-label ui |
|
@chessbyte @Fryguy can you please add reviewer(s), perhaps @martinpovolny and assign to someone as this is needed to move the ansible UI along. Thx, Dan |
|
@miq-bot add-label enhancement |
chessbyte
reviewed
Feb 23, 2017
| @@ -1,4 +1,5 @@ | |||
| class ManageIQ::Providers::AutomationManager < ::ExtManagementSystem | |||
| require_nested :Authentication | |||
There was a problem hiding this comment.
looks like this is already required a few lines below
mzazrivec
force-pushed
the
core_changes_for_ansible_credentials
branch
from
1aa9ff1 to
fcb0e93
Compare
|
Checked commit mzazrivec@fcb0e93 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
require_nested :AuthenticationintoManageIQ::Providers::AutomationManager