Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send data source properties when adding data source operation is performed #13937

Merged
merged 1 commit into from
Feb 17, 2017

Conversation

rubenvp8510
Copy link
Contributor

@rubenvp8510 rubenvp8510 commented Feb 16, 2017

Added datasource parameters to add_datasource operation

@miq-bot add_label providers/hawkular

@rubenvp8510 rubenvp8510 changed the title Add datasource parameters to add_datasource operation. Added datasource properties to add_datasource operation. Feb 16, 2017
@miq-bot
Copy link
Member

miq-bot commented Feb 16, 2017

Checked commit rubenvp8510@3e63ea7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🏆

@rubenvp8510 rubenvp8510 changed the title Added datasource properties to add_datasource operation. Send data source properties when adding data source operation is performed Feb 16, 2017
@mtho11
Copy link
Contributor

mtho11 commented Feb 16, 2017

@miq-bot assign @bronaghs

This is backend prerequisite to ManageIQ/manageiq-ui-classic#149

@miq-bot miq-bot assigned bronaghs and unassigned blomquisg Feb 16, 2017
@miq-bot
Copy link
Member

miq-bot commented Feb 16, 2017

@mtho11 unrecognized command 'label_add', ignoring...

Accepted commands are: add_label, remove_label, rm_label, assign, set_milestone

@mtho11
Copy link
Contributor

mtho11 commented Feb 16, 2017

@miq-bot add_label enhancement

@bronaghs
Copy link

LGTM 👍

@miq-bot assign @agrare

@miq-bot miq-bot assigned agrare and unassigned bronaghs Feb 17, 2017
@agrare agrare merged commit 6f61eb2 into ManageIQ:master Feb 17, 2017
@agrare agrare added this to the Sprint 55 Ending Feb 27, 2017 milestone Feb 17, 2017
@agrare
Copy link
Member

agrare commented Feb 17, 2017

@rubenvp8510 @mtho11 the manageiq-ui-classic PR is marked euwe/yes so I assume this should be as well? Is there a BZ for this?

@mtho11
Copy link
Contributor

mtho11 commented Feb 17, 2017

@agrare let me double check this with someone and get back to you on Monday (regarding euwe).

Thanks @agrare!

@mtho11
Copy link
Contributor

mtho11 commented Feb 20, 2017

@agrare discussed with others and there is no need to backport to euwe. That flag is removed from other PR as well.

@agrare
Copy link
Member

agrare commented Feb 20, 2017

Awesome thanks @mtho11 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants