Introducing find by and find or build by methods #13926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
reviewed
Feb 16, 2017
| def add_remaining_inventory_collections(defaults, inventory_collections_data = {}) | ||
| defaults.each do |default| | ||
| # Get names of all inventory collections defined in passed classes with Defaults | ||
| all_inventory_collections = default.methods - ::ManagerRefresh::InventoryCollectionDefault.methods |
There was a problem hiding this comment.
will methods(false) or public_methods(false) work for you?
There was a problem hiding this comment.
ah, will try that, thank you :-)
kbrock
changed the title
|
This pull request is not mergeable. Please rebase and repush. |
find_by and find_or_build_by methods for ICs having manager_ref consisting from multiple attributes
Ansible using find_or_build_by for Playbooks
Ladas
force-pushed
the
introducing_find_by_and_find_or_build_by_methods
branch
from
092f504 to
b58534f
Compare
Ladas
changed the title
|
@miq-bot remove_label wip |
|
Checked commits Ladas/manageiq@869a61d~...b58534f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked:
Introducing find_by and find_or_build_by methods
Only 2 last commits are relevant, rest is dependency