Use inventory object writers and readers instead of hash

app/models/manageiq/providers/ansible_tower/inventory/parser/automation_manager.rb

@@ -10,59 +10,61 @@ def parse
   def inventory_root_groups
     collector.inventories.each do |inventory|
       inventory_object = persister.inventory_root_groups.find_or_build(inventory.id.to_s)
-      inventory_object[:name] = inventory.name
+      inventory_object.name = inventory.name
     end
   end
 
   def configured_systems
     collector.hosts.each do |host|
       inventory_object = persister.configured_systems.find_or_build(host.id)
-      inventory_object[:hostname] = host.name
-      inventory_object[:virtual_instance_ref] = host.instance_id
-      inventory_object[:inventory_root_group] = persister.inventory_root_groups.lazy_find(host.inventory_id.to_s)
-      inventory_object[:counterpart] = Vm.find_by(:uid_ems => host.instance_id)
+      inventory_object.hostname = host.name
+      inventory_object.virtual_instance_ref = host.instance_id
+      inventory_object.inventory_root_group = persister.inventory_root_groups.lazy_find(host.inventory_id.to_s)
+      inventory_object.counterpart = Vm.find_by(:uid_ems => host.instance_id)
     end
   end
 
   def configuration_scripts
     collector.job_templates.each do |job_template|
       inventory_object = persister.configuration_scripts.find_or_build(job_template.id.to_s)
-      inventory_object[:description] = job_template.description
-      inventory_object[:name] = job_template.name
-      inventory_object[:survey_spec] = job_template.survey_spec_hash
-      inventory_object[:variables] = job_template.extra_vars_hash
-      inventory_object[:inventory_root_group] = persister.inventory_root_groups.lazy_find(job_template.inventory_id.to_s)
+      inventory_object.description = job_template.description
+      inventory_object.name = job_template.name
+      inventory_object.survey_spec = job_template.survey_spec_hash
+      inventory_object.variables = job_template.extra_vars_hash
+      inventory_object.inventory_root_group = persister.inventory_root_groups.lazy_find(job_template.inventory_id.to_s)
 
-      inventory_object[:authentications] = []
+      authentications = []
       %w(credential_id cloud_credential_id network_credential_id).each do |credential_attr|
         next unless job_template.respond_to?(credential_attr)
         credential_id = job_template.public_send(credential_attr).to_s
         next if credential_id.blank?
-        inventory_object[:authentications] << persister.credentials.lazy_find(credential_id)
+        authentications << persister.credentials.lazy_find(credential_id)
       end
+
+      inventory_object.authentications = authentications
     end
   end
 
   def configuration_script_sources
     collector.projects.each do |project|
       inventory_object = persister.configuration_script_sources.find_or_build(project.id.to_s)
-      inventory_object[:description] = project.description
-      inventory_object[:name] = project.name
+      inventory_object.description = project.description
+      inventory_object.name = project.name
 
       project.playbooks.each do |playbook_name|
         # FIXME: its not really nice how I have to build a manager_ref / uuid here
         inventory_object_playbook = persister.configuration_script_payloads.find_or_build("#{project.id}__#{playbook_name}")
-        inventory_object_playbook[:configuration_script_source] = inventory_object
-        inventory_object_playbook[:name] = playbook_name
+        inventory_object_playbook.configuration_script_source = inventory_object
+        inventory_object_playbook.name = playbook_name
       end
     end
   end
 
   def credentials
     collector.credentials.each do |credential|
       inventory_object = persister.credentials.find_or_build(credential.id.to_s)
-      inventory_object[:name] = credential.name
-      inventory_object[:userid] = credential.username
+      inventory_object.name = credential.name
+      inventory_object.userid = credential.username
       # credential.description
       # credential.host
       # credential.password
@@ -82,7 +84,7 @@ def credentials
       # credential.client
       # credential.authorize
       # credential.authorize_password
-      inventory_object[:type] = case credential.kind
+      inventory_object.type = case credential.kind
                                 when 'net' then 'ManageIQ::Providers::AnsibleTower::AutomationManager::NetworkCredential'
                                 when 'ssh' then 'ManageIQ::Providers::AnsibleTower::AutomationManager::MachineCredential'
                                 when 'vmware' then 'ManageIQ::Providers::AnsibleTower::AutomationManager::VmwareCredential'

app/models/manager_refresh/inventory_collection.rb

@@ -186,8 +186,12 @@ def lazy_find(manager_uuid, key: nil, default: nil)
       ::ManagerRefresh::InventoryObjectLazy.new(self, manager_uuid, :key => key, :default => default)
     end
 
+    def inventory_object_class
+      @inventory_object_class ||= Class.new(::ManagerRefresh::InventoryObject)
+    end
+
     def new_inventory_object(hash)
-      ::ManagerRefresh::InventoryObject.new(self, hash)
+      inventory_object_class.new(self, hash)
     end
 
     def build(hash)

app/models/manager_refresh/inventory_object.rb

@@ -3,7 +3,7 @@ class InventoryObject
     attr_accessor :object, :id
     attr_reader :inventory_collection, :data
 
-    delegate :manager_ref, :base_class_name, :to => :inventory_collection
+    delegate :manager_ref, :base_class_name, :model_class, :to => :inventory_collection
     delegate :[], :to => :data
 
     def initialize(inventory_collection, data)
@@ -91,6 +91,48 @@ def []=(key, value)
       value
     end
 
+    def allowed_writers
+      return [] unless model_class
+
+      # Get all writers of a model
+      @allowed_writers ||= (model_class.new.methods - Object.methods).grep(/^[\w]+?\=$/)
+    end
+
+    def allowed_readers
+      return [] unless model_class
+
+      # Get all readers inferred from writers of a model
+      @allowed_readers ||= allowed_writers.map { |x| x.to_s.delete("=").to_sym }
+    end
+
+    def method_missing(method_name, *arguments, &block)
+      if allowed_writers.include?(method_name)
+        self.class.define_data_writer(method_name)
+        send(method_name, arguments[0])
+      elsif allowed_readers.include?(method_name)
+        self.class.define_data_reader(method_name)
+        send(method_name)
+      else
+        super
+      end
+    end
+
+    def respond_to_missing?(method_name, _include_private = false)
+      allowed_writers.include?(method_name) || allowed_readers.include?(method_name) || super
+    end
+
+    def self.define_data_writer(data_key)
+      define_method(data_key) do |value|
+        send(:[]=, data_key.to_s.delete("=").to_sym, value)
+      end
+    end
+
+    def self.define_data_reader(data_key)
+      define_method(data_key) do
+        send(:[], data_key)
+      end
+    end
+
     private
 
     def association?(inventory_collection_scope, key)